Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Issue 2922: Help Box: CSS needs changes #502

Merged
merged 4 commits into from

3 participants

@sarken
Collaborator

Woohoo! I'm glad width/height auto worked. :)

Can you move #ibox_w's filter: alpha(opacity=60) to the ie8_and_lower style sheet, though? I know it was here in the original version, but it really shouldn't have been.

Also, this is more of a use-your-judgement thing, but you might want to use numbers from the standard em scale (http://otwcode.github.com/docs/front_end_coding/em-scale.html). If you think it looks better the way it is, that's fine!

@shalott shalott merged commit 815821b into from
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
This page is out of date. Refresh to see the latest.
View
8 public/javascripts/ibox/ibox.js
@@ -244,14 +244,6 @@ showIbox = function(url,title,params) {
ibox.onclick = null;getElem("ibox_close_a").onclick = function() {hideIbox();}
} else {ibox.onclick = hideIbox;getElem("ibox_close_a").onclick = null;}
- // adjust content height for IE7, which cannot inherit height
- /*@cc_on
- @if (@_jscript_version == 5.7)
- var wrapper = new getElementSize(getElem("ibox_wrapper"));
- getElem("ibox_content").style.height = (wrapper.height - 60) +"px";
- @end
- @*/
-
shown = true;
return true;
}
View
25 public/stylesheets/site/2.0/07-interactions.css
@@ -282,28 +282,24 @@ qTip2 Copyright 2009-2010 Craig Michael Thompson - http://craigsworks.com*/
word-wrap: break-word;
}
-/* WIDGET: IBOX (called by help links todo: REPLACE WITH KBD LIGHTBOX)*/
+/* WIDGET: IBOX (called by help links)*/
#ibox_w {
position: fixed;
top: 0;
- right: 0;
- bottom: 0;
left: 0;
z-index: 100;
width: 100%;
height: 100%;
background: #000;
opacity: 0;
- filter: Alpha(Opacity=60); /* IE7 and under */
- -ms-filter: Alpha(Opacity=60); /* IE8 */
}
#ibox_w, #ibox_wrapper {
- transition: opacity 400ms ease-out;
- -moz-transition: opacity 400ms ease-out;
+ transition: opacity 400ms ease-out;
+ -moz-transition: opacity 400ms ease-out;
-webkit-transition: opacity 400ms ease-out;
- -o-transition: opacity 400ms ease-out;
+ -o-transition: opacity 400ms ease-out;
}
#ibox_progress {
@@ -316,7 +312,7 @@ qTip2 Copyright 2009-2010 Craig Michael Thompson - http://craigsworks.com*/
#ibox_wrapper {
position: fixed;
z-index: 1000;
- padding: 0.643em 0.643em 2.5em;
+ padding: 0.643em 0.643em 2.571em;
border: 10px solid #eee;
background: #fff;
}
@@ -324,15 +320,14 @@ qTip2 Copyright 2009-2010 Craig Michael Thompson - http://craigsworks.com*/
#ibox_content {
font-size: 0.875em;
background: #fff;
- width: 100%; width: inherit;
- height: 100%; height: inherit;
+ width: auto;
+ height: auto;
overflow: auto;
- margin-bottom: 2px;
- padding: 4px 0 0 8px;
+ padding: 0.643em;
position: absolute;
top: 0;
right: 0;
- bottom: 30px;
+ bottom: 2.571em;
left: 0;
border-bottom: 1px solid #ccc;
}
@@ -345,7 +340,7 @@ qTip2 Copyright 2009-2010 Craig Michael Thompson - http://craigsworks.com*/
#ibox_footer {
position: absolute;
- bottom:8px;
+ bottom: 0.643em;
}
/*MODE: DYNAMIC is in early dev and so currently sharing styles with toggled */
View
8 public/stylesheets/site/2.0/28-role-ie8_or_lower.css
@@ -169,4 +169,10 @@ input, select, option, textarea, legend, label, .actions a {
display: none;
}
-/*DIAGNOSIS*/
+
+/* WIDGET: IBOX (called by help links)*/
+
+#ibox_w {
+ filter: alpha(opacity=60);
+}
Something went wrong with that request. Please try again.