Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated Recorded Talks Page #159

Merged
merged 19 commits into from
Jan 4, 2020
Merged

Updated Recorded Talks Page #159

merged 19 commits into from
Jan 4, 2020

Conversation

garrying
Copy link
Member

@garrying garrying commented Dec 4, 2019 •
edited
Loading

Fixes

Features

@garrying garrying added the WIP Work in progress label Dec 4, 2019
@garrying garrying mentioned this pull request Dec 4, 2019
Merged
@garrying garrying self-assigned this Dec 14, 2019
@garrying garrying mentioned this pull request Dec 14, 2019
Merged
@benhylau
Copy link
Member

benhylau commented Dec 17, 2019 •
edited
Loading

This looks good. #154 now targets this branch, and I made a minor adjustment in my PR here c03c2d2#diff-aeb42283af8ef8e9da40ededd3ae2ab2R17 to:

  • Remove the ipfs from the gateway and added it to the templates (since it's part of the protocol not the gw itself, otherwise we can't use the param for ipns)
  • Use ipfs.io as gateway

I suggest you check the ipfs.io gateway performance before merging. I am in an area without good internet, so everything plays choppy to me :)

@benhylau @garrying
Add redacted livestream archive files (#154)
c068386 
* Add redacted livestream archive files

* Fix share URL when m3u8 is passed in URL

* Change ts references to relative in live stream archive m3u8

* Switch to ipfs.io gateway for live and vod streams

* Remove hack that points our m3u8 fetch to live.mesh.world during conference

* Add live.m3u8 that points to next year message

* Use ipfs_gateway param in config everywhere and change to ipfs.io

* share cta visibility
@garrying
Copy link
Member Author

@benhylau Two thoughts after merging #154:

  • Does it make sense to hide the share controls on /video? My suggestion: 27cdcb8
  • The livestream links start at the end of stream rather than the start. Is there a way to have them start from the beginning?

benhylau
benhylau approved these changes Dec 19, 2019
View reviewed changes
Copy link
Member

@benhylau benhylau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, aside from https://travis-ci.com/ournetworks/ournetworks.ca/builds/141705862#L455

@garrying garrying removed the WIP Work in progress label Dec 19, 2019
@Shrinks99
Copy link

I know I wasn't asked to review this but there seems to be a slight issue with how multiple screen sizes are supported on the recorded talks list page. When the webpage is viewed at a small width the page does not resize properly which seems to be because links are not inheriting the size of their parent container because those links are long!
Screen Shot 2019-12-26 at 10 37 38 PM

Adding word-wrap: break-word; to the tag fixes this issue so we won't have a weird sideways scroll bar on mobile.

Other than that, I have tested both the livestream archive and this page and they seem to be good to go!

@garrying garrying merged commit 58355c8 into master Jan 4, 2020
@garrying garrying deleted the recorded-sessions-update branch January 4, 2020 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benhylau benhylau benhylau approved these changes

@ana0 ana0 ana0 approved these changes

@dcwalk dcwalk Awaiting requested review from dcwalk

@thinkbulecount2 thinkbulecount2 Awaiting requested review from thinkbulecount2

Assignees

@garrying garrying

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect share link when playing a live archive Speaker names not rendering on recorded talks page
4 participants
@garrying @benhylau @Shrinks99 @ana0