Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error parsing dib-lab/sourmash #60

Closed
luizirber opened this issue Jan 8, 2020 · 2 comments
Closed

Error parsing dib-lab/sourmash #60

luizirber opened this issue Jan 8, 2020 · 2 comments

Comments

@luizirber
Copy link

@luizirber luizirber commented Jan 8, 2020

Hi!

citeas is super cool! I saw an example with bokeh and tried it out with my project, sourmash... and it didn't work. From the bokeh output it seems we have even more sources (codemeta, citation.cff), but none is picked up?

While checking the API: http://api.citeas.org/product/https://github.com/dib-lab/sourmash
I noticed there is an error 500, so are we doing something too weird in the repo?

@caseydm

This comment has been minimized.

Copy link
Collaborator

@caseydm caseydm commented Jan 9, 2020

Hi! Glad you are enjoying citeas. This is fixed now. The error was on our end, in that we were not handing this portion of your codemeta file properly:

identifier: "",

We weren't treating that value as None, and were trying to parse a DOI that is sometimes there. But the script now sees that as an empty value and moves on. Take a look and let me know if you see any other issues.

@caseydm caseydm closed this Jan 9, 2020
@luizirber

This comment has been minimized.

Copy link
Author

@luizirber luizirber commented Jan 9, 2020

Thanks for the quick reply, @caseydm!

And... That's an error on our side, that identifier should be a DOI, and we should have authors listed too 🤣. I'll fix it and try again, but already glad to see it is showing up on citeas!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.