Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeError: Request path contains unescaped characters #2319

Closed
sentry-io bot opened this issue Jul 14, 2021 · 1 comment · Fixed by #2387
Closed

TypeError: Request path contains unescaped characters #2319

sentry-io bot opened this issue Jul 14, 2021 · 1 comment · Fixed by #2387
Assignees
Labels

Comments

@sentry-io
Copy link

sentry-io bot commented Jul 14, 2021

Happening in production, rarely enough that it's an edge case but unclear what specific data is causing this – one of the SSO providers is passing an invalid url for the team image?

Sentry Issue: OUTLINE-CLOUD-13A

TypeError: Request path contains unescaped characters
  ?, in new Promise
  File "/app/build/server/utils/s3.js", line 117, in uploadToS3FromUrl
    const res = await (0, _fetchWithProxy.default)(url);
  File "/app/build/server/models/Team.js", line 230, in Function.uploadAvatar
    const newUrl = await (0, _s.uploadToS3FromUrl)(avatarUrl, `avatars/${model.id}/${(0, _uuid.v4)()}`, "public-read");
  ?, in runMicrotasks
...
(15 additional frame(s) were not displayed)
@tommoor tommoor added the bug label Jul 14, 2021
tommoor added a commit that referenced this issue Jul 19, 2021
@tommoor
Copy link
Member

tommoor commented Jul 20, 2021

^ debugging commit above to catch what type of url is causing this next time it occurs in production

@tommoor tommoor added the blocked Something elsewhere needs changing first label Jul 21, 2021
@tommoor tommoor self-assigned this Jul 21, 2021
@tommoor tommoor removed the blocked Something elsewhere needs changing first label Jul 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
1 participant