New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React does not recognize the `iconVisible` prop on a DOM element #667

Closed
enzolutions opened this Issue Jun 5, 2018 · 2 comments

Comments

Projects
None yet
2 participants
@enzolutions

enzolutions commented Jun 5, 2018

Hi folks,

Running outline in dev mode, I got a warning in Console

warning.js?6327:33 Warning: React does not recognize the `iconVisible` prop on a DOM element. If you intentionally want it to appear in the DOM as a custom attribute, spell it as lowercase `iconvisible` instead. If you accidentally passed it from a parent component, remove it from the DOM element.
    in a (created by Link)
    in Link (created by Route)
    in Route (created by NavLink)
    in NavLink (created by SidebarLink__StyledNavLink)
    in SidebarLink__StyledNavLink (created by SidebarLink)
    in div (created by Flex__Container)
    in Flex__Container (created by Flex)
    in Flex (created by SidebarLink__Wrapper)
    in SidebarLink__Wrapper (created by SidebarLink)
    in SidebarLink (created by Route)
    in Route (created by withRouter(SidebarLink))
    in withRouter(SidebarLink) (created by MainSidebar)
    in div (created by Flex__Container)
    in Flex__Container (created by Flex)
    in Flex (created by Sidebar__Section)
    in Sidebar__Section (created by MainSidebar)
    in div (created by Scrollable__Wrapper)
    in Scrollable__Wrapper (created by Scrollable)
    in Scrollable (created by MainSidebar)
    in div (created by Flex__Container)
    in Flex__Container (created by Flex)
    in Flex (created by MainSidebar)
    in div (created by Flex__Container)
    in Flex__Container (created by Flex)
    in Flex (created by Sidebar__Container)
    in Sidebar__Container (created by Sidebar)
    in Sidebar (created by inject-Sidebar-with-ui)
    in inject-Sidebar-with-ui (created by Route)
    in Route (created by withRouter(inject-Sidebar-with-ui))
    in withRouter(inject-Sidebar-with-ui) (created by MainSidebar)
    in MainSidebar (created by inject-MainSidebar-with-user-documents-auth-ui)
    in inject-MainSidebar-with-user-documents-auth-ui (created by Route)
    in Route (created by withRouter(inject-MainSidebar-with-user-documents-auth-ui))
    in withRouter(inject-MainSidebar-with-user-documents-auth-ui) (created by Route)
    in Route (created by Layout)
    in Switch (created by Layout)
    in div (created by Flex__Container)
    in Flex__Container (created by Flex)
    in Flex (created by Layout)
    in div (created by Flex__Container)
    in Flex__Container (created by Flex)
    in Flex (created by Layout__Container)
    in Layout__Container (created by Layout)
    in Layout (created by inject-Layout-with-user-auth-ui-documents)
    in inject-Layout-with-user-auth-ui-documents (created by Route)
    in Route (created by withRouter(inject-Layout-with-user-auth-ui-documents))
    in withRouter(inject-Layout-with-user-auth-ui-documents)
    in Provider (created by _class)
    in _class (created by inject-_class-with-auth)
    in inject-_class-with-auth
    in Switch
    in ScrollToTop (created by Route)
    in Route (created by withRouter(ScrollToTop))
    in withRouter(ScrollToTop)
    in Router (created by BrowserRouter)
    in BrowserRouter
    in Provider
    in ErrorBoundary

I think is related with StyledNavLink object located at SidebarLink.js

@tommoor tommoor added the bug label Jun 5, 2018

@tommoor

This comment has been minimized.

Member

tommoor commented Jun 5, 2018

Yea, I've been seeing that - it's just a bit tricky to fix because of the way that styled-components works and wasn't causing any issues so It's been low priority. Happy to accept a PR to fix 😄

@enzolutions

This comment has been minimized.

enzolutions commented Jun 5, 2018

If you give me a guideline about how to fix I would try.

@tommoor tommoor self-assigned this Jun 5, 2018

@tommoor tommoor closed this in 97c2d8d Jun 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment