Skip to content

♻️ refacto(kube): refactored kubectl args & flags#189

Merged
jfbus merged 1 commit into
mainfrom
kubectl_flags
May 19, 2026
Merged

♻️ refacto(kube): refactored kubectl args & flags#189
jfbus merged 1 commit into
mainfrom
kubectl_flags

Conversation

@jfbus
Copy link
Copy Markdown
Contributor

@jfbus jfbus commented May 19, 2026

Description

The octl kube kubectl was problematic:

  • it was not coherent with the other commands - cluster should be a flag, not an arg,
  • the global flags were not parsed, forbidding the use of --config/--profile.

Type of Change

Please check the relevant option(s):

  • 🐛 Bug fix
  • ✨ New feature
  • 🧹 Code cleanup or refactor
  • 📝 Documentation update
  • 🔧 Build or CI-related change
  • 🔒 Security fix
  • Other (specify):

How Has This Been Tested?

Please describe the test strategy:

  • Manual testing
  • Unit tests
  • Integration tests
  • Not tested yet

Checklist

  • I have followed the Contributing Guidelines
  • I have added tests or explained why they are not needed
  • I have updated relevant documentation (README, examples, etc.)
  • My changes follow the Conventional Commits specification
  • My commits include appropriate Gitmoji

Additional Context

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 19, 2026

WARNING : Differences in reference doc 🤔

 docs/reference/octl_kube_kubectl.md | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)
Detailed changes

docs/reference/octl_kube_kubectl.md

-Example: octl kube kubectl cluster_name get pods -o wide
+Example: octl kube kubectl --cluster cluster_name -- get pods -o wide
-octl kube kubectl cluster_name [kubectl_args] [kubectl_flags] [flags]
+octl kube kubectl [octl_flags] -- kubectl_args [kubectl_flags] [flags]
+      --cluster string   Name or ID of cluster

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 19, 2026

Binary size: 81.6MB => 81.6MB (change +0KB, +0.0%) 😉

@jfbus jfbus marked this pull request as ready for review May 19, 2026 14:22
@jfbus jfbus requested a review from a team May 19, 2026 14:22
@jfbus jfbus requested a review from a team as a code owner May 19, 2026 14:22
@jfbus jfbus force-pushed the kubectl_flags branch 2 times, most recently from adbba2a to f3a57f6 Compare May 19, 2026 14:29
@jfbus jfbus merged commit 70f64bd into main May 19, 2026
11 of 12 checks passed
@jfbus jfbus deleted the kubectl_flags branch May 19, 2026 15:46
@jfbus jfbus added the kind/refactoring Refactoring or internal changes label May 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/refactoring Refactoring or internal changes

Development

Successfully merging this pull request may close these issues.

2 participants