Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SingleValueHeaders and http2/grpc #8940

Closed
daniel-lucas-silva opened this issue Feb 16, 2024 · 0 comments · Fixed by #8957
Closed

SingleValueHeaders and http2/grpc #8940

daniel-lucas-silva opened this issue Feb 16, 2024 · 0 comments · Fixed by #8957
Labels
bug Something isn't working node.js Compatibility with Node.js APIs

Comments

@daniel-lucas-silva
Copy link

daniel-lucas-silva commented Feb 16, 2024 •
edited
Loading

What version of Bun is running?

1.0.27+d49cb0b98

What platform is your computer?

Darwin 22.1.0 arm64 arm

What steps can reproduce the bug?

I have upgraded to Canary (1.0.27) and got this problem in debugger

Screenshot 2024-02-16 at 05 58 56

I think it's an issue with bun's h2 parser
Screenshot 2024-02-16 at 06 02 57

This is the headers sent to @grpc/grpc-js, same in node
Screenshot 2024-02-16 at 06 04 07

What is the expected behavior?

I patched locally the grpc-js converting manually authorization header and firestore has been working

What do you see instead?

No response

Additional information

No response
@daniel-lucas-silva daniel-lucas-silva added the bug Something isn't working label Feb 16, 2024
@Electroid Electroid added the node.js Compatibility with Node.js APIs label Feb 16, 2024
Jarred-Sumner added a commit that referenced this issue Feb 17, 2024
@Jarred-Sumner
Fixes #8940
0780748
@Jarred-Sumner Jarred-Sumner mentioned this issue Feb 17, 2024
Merged
Jarred-Sumner added a commit that referenced this issue Feb 17, 2024
@Jarred-Sumner
Fixes #8940 (#8957)
a6acb25 
Co-authored-by: Jarred Sumner <709451+Jarred-Sumner@users.noreply.github.com>
@brianmhunt brianmhunt mentioned this issue Jul 16, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working node.js Compatibility with Node.js APIs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes #8940 oven-sh/bun
2 participants
@Electroid @daniel-lucas-silva