types: Rewrite to avoid conflicts and allow for doc generation - #18024
Merged
Conversation
Collaborator
|
Updated 9:26 AM PT - Mar 25th, 2025
❌ @alii, your commit 6800a90 has 2 failures in
🧪 try this PR locally: bunx bun-pr 18024 |
Member
Author
|
@Jarred-Sumner it seems like the failing tests are unrelated to changes in this PR. How can we resolve? |
Collaborator
|
They’re only failing in this branch. It’s likely related to the
tsconfig.json changes
…On Tue, Mar 25, 2025 at 3:42 AM Alistair Smith ***@***.***> wrote:
@Jarred-Sumner <https://github.com/Jarred-Sumner> it seems like the
failing tests are unrelated to changes in this PR. How can we resolve?
—
Reply to this email directly, view it on GitHub
<#18024 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAFNGSYHCIVIK45UI2BDY6L2WEQG3AVCNFSM6AAAAABYUST6YOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDONJQHAZTCMJUHE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
[image: alii]*alii* left a comment (oven-sh/bun#18024)
<#18024 (comment)>
@Jarred-Sumner <https://github.com/Jarred-Sumner> it seems like the
failing tests are unrelated to changes in this PR. How can we resolve?
—
Reply to this email directly, view it on GitHub
<#18024 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAFNGSYHCIVIK45UI2BDY6L2WEQG3AVCNFSM6AAAAABYUST6YOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDONJQHAZTCMJUHE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
KilianB
reviewed
Mar 25, 2025
This was referenced Mar 25, 2025
This was referenced Mar 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR rearranges all of bun-types to in a way that eliminates conflicts with Node.js AND lib.dom.d.ts, as well as declaring the
Bunnamespace and other symbols in a way we can generate documentation from.Fixes #13599
Fixes #8761
Fixes #13167
Fixes #17203
Fixes #17256
Fixes #13858
Fixes #16044
Fixes #18458
Fixes #17980
Fixes #14660
Fixes #8765
Fixes #17940
Fixes #16785
Fixes #16537
Fixes #14892
Fixes #13669
Fixes #12662
Fixes #358
todo:
publish @oven/typescript-bun-lib-domfigure out CI for autopatching dom..? (might not be necessary)see if we can get BodyInit & HeadersInit to be declared inside of Bun types, not dom