Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for uBO 1.25.0 #305

Closed
wants to merge 5 commits into from
Closed

fix for uBO 1.25.0 #305

wants to merge 5 commits into from

Conversation

stonecrusher
Copy link
Contributor

I fixed my personal CSS for uBO 1.25.0 and think it will also suit everyone else. Only thing is that I didn't use color variables everywhere, but also "absolute" colors. So you may have a look at it, but it works for default.

@ghost
Copy link

ghost commented Feb 26, 2020

It seems like you only used absolute colours where it was more necessary (as in, there were no appropriate variables in the colour scheme, because it was trying to show a rainbow or something)? That seems fine to me.

Thanks for taking care of this.

@stonecrusher
Copy link
Contributor Author

@overdodactyl Please consider having a look at this repo / PRs after that year of stasis.

@ghost
Copy link

ghost commented May 21, 2020

By the way, latest uBlock has changed the UI again, and it's gotten worse for us I'm afraid:

image

Not sure if the above patch would still resolve this?

I've read that there is a plan to include a dark interface within the addon itself, but until then.... It would be good to see you @overdodactyl :)

@stonecrusher
Copy link
Contributor Author

Not sure if the above patch would still resolve this?

No it doesn't.
They had quite a big makeover concerning the structure, selectors and so on.
But I am positive it won't take too long for a native dark style as everything is already set up for dark style and you more or less just need to fill in the dark colors for the ~30 variables.

@hyiltiz
Copy link

hyiltiz commented Nov 29, 2020

My uBo still looks like the one shown above: https://docs.google.com/spreadsheets/d/1ZZ8JeDjz7C5cRVl8ovYYm2L3E0mjjebCxN7WUK1Nw2A. I just updated shadowfox as instructed (to the 2019 Jun 1 version). Is everything also seeing this and we are all awaiting a fix?

@stonecrusher
Copy link
Contributor Author

It's not perfect / completely finished yet, but by now you can activate the built-in dark mode of uBO.

In the advanced settings, set uiTheme to dark.
https://github.com/gorhill/uBlock/wiki/Advanced-settings#uitheme

@stonecrusher stonecrusher closed this by deleting the head repository Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants