Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue running ecommerce in development mode #16

Closed
BbrSofiane opened this issue Sep 24, 2021 · 3 comments
Closed

Issue running ecommerce in development mode #16

BbrSofiane opened this issue Sep 24, 2021 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@BbrSofiane
Copy link
Member

BbrSofiane commented Sep 24, 2021

Bug description

With the introduction of the ecommerce mfe, the development command:

tutor dev runserver ecommerce

Now starts the ecommerce mfe and without starting the e-commerce service.

Solution
Change

"MFE_APP": {
   "name": "ecommerce",
   "repository": "https://github.com/edx/frontend-app-ecommerce",
   "port": 1996,
},

to

"MFE_APP": {
    "name": "ecommercemfe",
    "repository": "https://github.com/edx/frontend-app-ecommerce",
    "port": 1996,
},

@overhangio/tutor-developers what do you think?

@regisb
Copy link
Contributor

regisb commented Sep 24, 2021

hmmmm good catch. Yes, this is a bug.

The problem with your suggested solution is that it will cause the ecommerce MFE to be served from http://appsyourlms.com/ecommercemfe -- which is not great. I mean: I like your solution, but I think we should try to find a different name. The ecommerce MFE is itself not very well named; after all the only thing it does is to display the user order history. So, could we simply use "name": "orderhistory"?

@BbrSofiane
Copy link
Member Author

True I didn't think about the URL.

I thought about calling it orderhistory but it means that if there is more functionality added to it we might have to change the name. I'm making the assumption that since edX called the repo frontend-app-ecommerce they might add functionality beyond order history.

But I think for now orderhistory sounds good!

@BbrSofiane BbrSofiane self-assigned this Sep 24, 2021
@regisb
Copy link
Contributor

regisb commented Sep 27, 2021

Maybe "orderhistory" is overly precise and we could go with simply "orders"?

@regisb regisb added the bug Something isn't working label Sep 27, 2021
sergivalero20 pushed a commit to Pearson-Advance/tutor-ecommerce that referenced this issue Mar 23, 2023
- [Bugfix] Fix "Invalid type for parameter ContentType" error on js
upload in Scorm xblock ([openedx-scorm-xblock overhangio#16](overhangio/openedx-scorm-xblock#16))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Development

No branches or pull requests

2 participants