Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the ability to customize CMS and LMS Features setting. #276

Closed
cacciaresi opened this issue Dec 11, 2019 · 1 comment
Closed

Add the ability to customize CMS and LMS Features setting. #276

cacciaresi opened this issue Dec 11, 2019 · 1 comment

Comments

@cacciaresi
Copy link
Contributor

@cacciaresi cacciaresi commented Dec 11, 2019

Is your feature request related to a problem? Please describe.

We needed to customize only LMS Features setting in its config file, we didn't want to have the new setting entry in CMS settings.

Describe the solution you'd like

We have added this change in lms.env.json:
{{ patch("lms-env-features", separator=",\n", suffix=",")|indent(4) }}

and this in cms.env.json:
{{ patch("cms-env-features", separator=",\n", suffix=",")|indent(4) }}

By doing this then we can add a file named: lms-env-features in a plugin and that will add the setting only in the LMS settings.

@regisb

This comment has been minimized.

Copy link
Collaborator

@regisb regisb commented Dec 12, 2019

This sounds reasonable. Would you like to make a PR?

@regisb regisb closed this in 2ee5b49 Dec 16, 2019
regisb added a commit that referenced this issue Dec 21, 2019
v3.9.0
- [Security] Apply django 1.11.21 -> 1.11.27 security patches
- [Bugfix] Fix running dev image with `sudo`
- [Improvement] Add `cms/lms-env-features` patches (#276)
- [Feature] Add plugin subcommands
- 💥[Improvement] Move ``-r/--root`` option to parent command level
- [Bugfix] Fix course about page visibility
- [Improvement] Print gunicorn access logs in the console
- 💥[Improvement] Get rid of the `indexcourses` and `portainer` command
(#269)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.