From 49f3b7d54f06e1946881f073d78a82f8f53d70d4 Mon Sep 17 00:00:00 2001 From: Henry Oswald Date: Fri, 23 Nov 2018 14:52:13 +0000 Subject: [PATCH] have failed compiles warn rather than be an error --- app/coffee/CompileController.coffee | 4 ++-- test/unit/coffee/CompileControllerTests.coffee | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/app/coffee/CompileController.coffee b/app/coffee/CompileController.coffee index 5d1ee2e7..0a51c947 100644 --- a/app/coffee/CompileController.coffee +++ b/app/coffee/CompileController.coffee @@ -33,7 +33,7 @@ module.exports = CompileController = else status = "error" code = 500 - logger.error err: error, project_id: request.project_id, "error running compile" + logger.warn err: error, project_id: request.project_id, "error running compile" else status = "failure" @@ -42,7 +42,7 @@ module.exports = CompileController = status = "success" if status == "failure" - logger.err project_id: request.project_id, outputFiles:outputFiles, "project failed to compile successfully, no output.pdf generated" + logger.warn project_id: request.project_id, outputFiles:outputFiles, "project failed to compile successfully, no output.pdf generated" # log an error if any core files are found for file in outputFiles diff --git a/test/unit/coffee/CompileControllerTests.coffee b/test/unit/coffee/CompileControllerTests.coffee index f0269ee3..529c7322 100644 --- a/test/unit/coffee/CompileControllerTests.coffee +++ b/test/unit/coffee/CompileControllerTests.coffee @@ -14,7 +14,7 @@ describe "CompileController", -> clsi: url: "http://clsi.example.com" "./ProjectPersistenceManager": @ProjectPersistenceManager = {} - "logger-sharelatex": @logger = { log: sinon.stub(), error: sinon.stub(), err:sinon.stub() } + "logger-sharelatex": @logger = { log: sinon.stub(), error: sinon.stub(), err:sinon.stub(), warn: sinon.stub()} @Settings.externalUrl = "http://www.example.com" @req = {} @res = {}