Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .nvmrc #52

Merged
merged 1 commit into from Feb 25, 2014

Conversation

Projects
None yet
2 participants
@cirosantilli
Copy link
Contributor

commented Feb 25, 2014

Add a .nvmrc with recommended version, tell people to use nvm and show them how. Newb friendly.

@jpallen

This comment has been minimized.

Copy link
Contributor

commented Feb 25, 2014

I like the inclusion of the .nvmrc file (can we bump it to the latest version: 0.10.26?).

I think the README instructions are now too complicated though. Not everyone will be using nvm, or want to. Likewise, many people will have Node already installed. This is mixing the set up of dependencies vs the set up ShareLaTeX. The install instructions are meant to be just setting up ShareLaTeX.

@jpallen

This comment has been minimized.

Copy link
Contributor

commented Feb 25, 2014

Also, I think a better option would be to link to the nvm website/repo for installation instructions for Node/nvm, otherwise we have to keep another set of installation instructions for a package we don't maintain, and that already have good install docs.

@cirosantilli

This comment has been minimized.

Copy link
Contributor Author

commented Feb 25, 2014

I understand.

Can I at least recommend that people use nvm in the README, and add instructions to the wiki? It is probably the best option for every system, and if I had those instructions, I would have gained one hour (even after looking at the nvm site).

@jpallen

This comment has been minimized.

Copy link
Contributor

commented Feb 25, 2014

That sounds like a good idea. Expanding the Node.js item in the
dependencies section would be a good place to put this.

On Tue, Feb 25, 2014 at 12:47 PM, Ciro Santilli notifications@github.comwrote:

I understand.

Can I at least recommend that people use nvm in the README, and add
instructions to the wiki? It is probably the best option for every system,
and if I had those instructions, I would have gained one hour (even after
looking at the nvm site).

Reply to this email directly or view it on GitHubhttps://github.com//pull/52#issuecomment-36003671
.

@cirosantilli

This comment has been minimized.

Copy link
Contributor Author

commented Feb 25, 2014

How about this?

@jpallen

This comment has been minimized.

Copy link
Contributor

commented Feb 25, 2014

Yes, I like that. Can you change the version to 0.10.26 please, and still mention the version explicitly in the README incase people aren't using nvm?

@cirosantilli

This comment has been minimized.

Copy link
Contributor Author

commented Feb 25, 2014

Sory about the 10.9, from now on only git tag | sort -V.

jpallen added a commit that referenced this pull request Feb 25, 2014

@jpallen jpallen merged commit 7713de2 into overleaf:master Feb 25, 2014

@jpallen

This comment has been minimized.

Copy link
Contributor

commented Feb 25, 2014

Great, thanks

@cirosantilli cirosantilli deleted the cirosantilli:add-nvmrc branch Feb 25, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.