Added more business milestones to track where failures happen #476
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavidS-ovm
reviewed
Jul 19, 2024
Contributor
DavidS-ovm
left a comment
DavidS-ovm
left a comment
There was a problem hiding this comment.
I would suggest two major changes here:
- move all detection logic into a single function at the cmdModel to have a better overview of what this is tracking across the entire CLI
- capture and re-use key attributes at the cmdModel level (accountName, user id, etc) so that all honeycomb queries can slice and dice by the same filters
Fixes #473
DavidS-ovm
approved these changes
Jul 19, 2024
cmd/tea_submitplan.go
Outdated
Comment on lines
684
to
686
|
|
||
| // TODO: Ask David about the position of these too | ||
| sentry.CaptureException(err) |
Contributor
There was a problem hiding this comment.
I haven't dug in more closely what's happening here, but for all errors, there is
Line 161 in 6c2f300
risksError does return a fatalError that is propagated up, so it should already land in sentry.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #470