Skip to content

Minor improvements #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 22, 2023
Merged

Minor improvements #50

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c5129d7
Fix create-bookmark output to stdout
DavidS-ovm Aug 22, 2023
3b22f42
Implement request --ignore-cache
DavidS-ovm Aug 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cmd/createbookmark.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ func CreateBookmark(signals chan os.Signal, ready chan bool) int {
if err != nil {
log.Infof("Error rendering bookmark: %v", err)
} else {
log.Info(string(b))
fmt.Println(string(b))
}

return 0
Expand Down
7 changes: 5 additions & 2 deletions cmd/request.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,7 @@ func Request(signals chan os.Signal, ready chan bool) int {
// nolint: bodyclose // nhooyr.io/websocket reads the body internally
c, _, err := websocket.Dial(ctx, gatewayUrl, options)
if err != nil {
lf["gateway-url"] = gatewayUrl
log.WithContext(ctx).WithFields(lf).WithError(err).Error("Failed to connect to overmind API")
return 1
}
Expand Down Expand Up @@ -342,8 +343,9 @@ func createInitialRequest() (*sdp.GatewayRequest, error) {
msgID := uuid.New()
req.RequestType = &sdp.GatewayRequest_LoadBookmark{
LoadBookmark: &sdp.LoadBookmark{
UUID: bookmarkUUID[:],
MsgID: msgID[:],
UUID: bookmarkUUID[:],
MsgID: msgID[:],
IgnoreCache: viper.GetBool("ignore-cache"),
},
}
case "load-snapshot":
Expand Down Expand Up @@ -374,6 +376,7 @@ func init() {
requestCmd.PersistentFlags().String("query-type", "*", "The type to query")
requestCmd.PersistentFlags().String("query", "", "The actual query to send")
requestCmd.PersistentFlags().String("query-scope", "*", "The scope to query")
requestCmd.PersistentFlags().Bool("ignore-cache", false, "Set to true to ignore all caches in overmind.")

requestCmd.PersistentFlags().String("bookmark-uuid", "", "The UUID of the bookmark to load")
requestCmd.PersistentFlags().String("snapshot-uuid", "", "The UUID of the snapshot to load")
Expand Down