Port "ensureToken" over to PTerm #523
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavidS-ovm
force-pushed
the
pterm-ensuretoken
branch
from
8737bfd to
7fdfbd7
Compare
Member
dylanratcliffe
left a comment
dylanratcliffe
left a comment
There was a problem hiding this comment.
That's way easier to understand from my perspective
DavidS-ovm
force-pushed
the
pterm-ensuretoken
branch
3 times, most recently
from
85f9fe6 to
cf2bbee
Compare
Contributor
Author
|
Updated with the |
DavidS-ovm
force-pushed
the
pterm-ensuretoken
branch
from
cf2bbee to
4d00fc8
Compare
DavidS-ovm
force-pushed
the
pterm-ensuretoken
branch
3 times, most recently
from
40e9114 to
9c10c4b
Compare
Contributor
Author
|
This will still require more work and fine-tuning before merging, but it already |
17 tasks
DavidS-ovm
force-pushed
the
pterm-ensuretoken
branch
3 times, most recently
from
934cf98 to
5dea9f9
Compare
DavidS-ovm
force-pushed
the
pterm-ensuretoken
branch
from
f5f6cff to
6eeb4fe
Compare
Contributor
Author
|
This is now ready for final reviews. |
Member
|
I think that running through this tomorrow, showing off the updated commands is the way to go. Nothing is jumping out on visual inspection |
DavidS-ovm
force-pushed
the
pterm-ensuretoken
branch
from
4168c35 to
e469f1d
Compare
tphoney
requested changes
Sep 20, 2024
Run sources locally using terraform's configured authorization to provide data when using https://app.overmind.tech/explore
this removes some effort from callers and allows a consistent look across all of them, while preserving the flexibility to pass in a custom writer to exactly control where the spinner goes.
…output Commands like submit-plan expect stdout to be clean to pass change-url through when being used in the github action. This ensures that progress information is a) displayed in CI and b) does not interfere with that usage. Commands that are meant to be used interactively can provide their own writer, like the `terraform` subcommands do.
DavidS-ovm
force-pushed
the
pterm-ensuretoken
branch
from
695b8f8 to
071861e
Compare
Contributor
Author
|
rebased on top of the latest go.mod changes |
Member
Dat ratio |
dylanratcliffe
approved these changes
Sep 20, 2024
| // exploreCmd represents the explore command | ||
| var exploreCmd = &cobra.Command{ | ||
| Use: "explore", | ||
| Short: "Run local sources for using in the Explore page", |
Member
There was a problem hiding this comment.
I don't think it should block the merge but I'd like @jameslaneovermind to look at the descriptions here and jazz them up a bit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces most of https://github.com/overmindtech/cli/blob/main/cmd/root.go#L250-L377 (which is still used elsewhere for now).
Results:
It's not fully 1/1 identical to the bubbletea behaviour, but it is SO. MUCH. LESS. CODE.