Skip to content

Added shutdown spinner & auto-populate code #614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 16, 2024
+12 −1
Merged

Added shutdown spinner & auto-populate code #614

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions cmd/explore.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,6 +204,11 @@ func Explore(cmd *cobra.Command, args []string) error {
return fmt.Errorf("error reading keyboard input: %w", err)
}

// This spinner will spin forever as the command shuts down as this could
// take a couple of seconds and we want the user to know it's doing
// something
_, _ = pterm.DefaultSpinner.WithWriter(multi.NewWriter()).Start("Shutting down")

return nil
}

Expand Down
8 changes: 7 additions & 1 deletion cmd/root.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -488,8 +488,14 @@ func getOauthToken(ctx context.Context, oi sdp.OvermindInstance, requiredScopes
}

var token *oauth2.Token
var urlToOpen string
if deviceCode.VerificationURIComplete != "" {
urlToOpen = deviceCode.VerificationURIComplete
} else {
urlToOpen = deviceCode.VerificationURI
}

_ = browser.OpenURL(deviceCode.VerificationURI) // nolint:errcheck // we don't care if the browser fails to open
_ = browser.OpenURL(urlToOpen) // nolint:errcheck // we don't care if the browser fails to open
pterm.Print(
markdownToString(MAX_TERMINAL_WIDTH, fmt.Sprintf(
beginAuthMessage,
Expand Down
Loading