Skip to content

Increase default timeouts to 5min #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 28, 2023
Merged

Increase default timeouts to 5min #80

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cmd/createbookmark.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,5 +135,5 @@ func init() {

createBookmarkCmd.PersistentFlags().String("file", "", "JSON formatted file to read bookmark. (defaults to stdin)")

createBookmarkCmd.PersistentFlags().String("timeout", "1m", "How long to wait for responses")
createBookmarkCmd.PersistentFlags().String("timeout", "5m", "How long to wait for responses")
}
2 changes: 1 addition & 1 deletion cmd/endchange.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,5 +109,5 @@ func init() {

endChangeCmd.PersistentFlags().String("frontend", "https://app.overmind.tech/", "The frontend base URL")

endChangeCmd.PersistentFlags().String("timeout", "1m", "How long to wait for responses")
endChangeCmd.PersistentFlags().String("timeout", "5m", "How long to wait for responses")
}
2 changes: 1 addition & 1 deletion cmd/getaffectedbookmarks.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,5 +113,5 @@ func init() {
getAffectedBookmarksCmd.PersistentFlags().String("snapshot-uuid", "", "The UUID of the snapshot that should be checked.")
getAffectedBookmarksCmd.PersistentFlags().String("bookmark-uuids", "", "A comma separated list of UUIDs of the potentially affected bookmarks.")

getAffectedBookmarksCmd.PersistentFlags().String("timeout", "1m", "How long to wait for responses")
getAffectedBookmarksCmd.PersistentFlags().String("timeout", "5m", "How long to wait for responses")
}
2 changes: 1 addition & 1 deletion cmd/getchange.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,5 +141,5 @@ func init() {
getChangeCmd.PersistentFlags().String("frontend", "https://app.overmind.tech/", "The frontend base URL")
getChangeCmd.PersistentFlags().String("format", "json", "How to render the change. Possible values: json, markdown")

getChangeCmd.PersistentFlags().String("timeout", "1m", "How long to wait for responses")
getChangeCmd.PersistentFlags().String("timeout", "5m", "How long to wait for responses")
}
2 changes: 1 addition & 1 deletion cmd/getsnapshot.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,5 +124,5 @@ func init() {

getSnapshotCmd.PersistentFlags().String("uuid", "", "The UUID of the snapshot that should be displayed.")

getSnapshotCmd.PersistentFlags().String("timeout", "1m", "How long to wait for responses")
getSnapshotCmd.PersistentFlags().String("timeout", "5m", "How long to wait for responses")
}
2 changes: 1 addition & 1 deletion cmd/request.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -404,7 +404,7 @@ func init() {
requestCmd.PersistentFlags().String("snapshot-name", "CLI", "The snapshot name of the query results")
requestCmd.PersistentFlags().String("snapshot-description", "none", "The snapshot description of the query results")

requestCmd.PersistentFlags().String("timeout", "1m", "How long to wait for responses")
requestCmd.PersistentFlags().String("timeout", "5m", "How long to wait for responses")
requestCmd.PersistentFlags().Uint32("link-depth", 0, "How deeply to link")
requestCmd.PersistentFlags().Bool("blast-radius", false, "Whether to query using blast radius, note that if using this option, link-depth should be set to > 0")
}
4 changes: 2 additions & 2 deletions cmd/startchange.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ func StartChange(signals chan os.Signal, ready chan bool) int {
))
defer span.End()

ctx, err = ensureToken(ctx, []string{"changes:write"},signals)
ctx, err = ensureToken(ctx, []string{"changes:write"}, signals)
if err != nil {
log.WithContext(ctx).WithFields(log.Fields{
"url": viper.GetString("url"),
Expand Down Expand Up @@ -109,5 +109,5 @@ func init() {

startChangeCmd.PersistentFlags().String("frontend", "https://app.overmind.tech/", "The frontend base URL")

startChangeCmd.PersistentFlags().String("timeout", "1m", "How long to wait for responses")
startChangeCmd.PersistentFlags().String("timeout", "5m", "How long to wait for responses")
}