♻️ 161 - replace freactal #168
Open
+4,687
−3,521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joneubank
previously approved these changes
May 27, 2021
| }), | ||
| ); | ||
| const enhance = compose(); | ||
| // defaultProps({ |
There was a problem hiding this comment.
remove unused code comments
| }) => { | ||
| stageChange, | ||
| } = useEntityContext(); | ||
| // withState('items', 'setItems', ({ associatedItems }) => associatedItems), |
There was a problem hiding this comment.
remove unused code comments
| if (!egoJwt || !egoPublicKey) { | ||
| return false; | ||
| } else { | ||
| return jwt.verify(egoJwt, egoPublicKey, { algorithms: ['RS256'] }) && true; |
There was a problem hiding this comment.
Not sure why we have && true... if the intention is to force boolean return type, maybe we want !!jwt.verify(...)
| export const isValidJwt = verifyJwt(EGO_PUBLIC_KEY); | ||
|
|
||
| export const decodeToken: (egoJwt?: string) => EgoJwtData | null = memoize((egoJwt) => | ||
| egoJwt && isValidJwt(egoJwt) ? jwtDecode(egoJwt) : null, |
There was a problem hiding this comment.
egoJwt && isn't necessary as this is checked in isValidJwt(egoJwt)
Refactor resource map
206 - Refactor nav
wip - initial table load with list provider
Parent table with params
* Initialize entity context with id, reorganize providers * load entity into context * Add user meta components, common panel components * rename panelcomponents * Add fieldnames enum * pr feedback
* Initialize entity context with id, reorganize providers * load entity into context * Add user meta components, common panel components * Add fieldnames enum * add group meta comp * add policy and application content panels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes freactal dependency.
Replaces freactal stateProviders with context providers.
Adds jwt validation. Force logout on expired token.
Disable button calls patch update immediately, no staging changes + save
Small modification to sort behaviour, offset will not reset to
0when sort direction/field is changed