Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Score doc revamp #154

Merged
merged 10 commits into from May 13, 2021
Merged

Score doc revamp #154

merged 10 commits into from May 13, 2021

Conversation

b-f-chan
Copy link
Contributor

@b-f-chan b-f-chan commented May 9, 2021

Hey @jaserud, I'm really sorry for the delay, but here's the final Score docs for review. I dug into the Score code and there were a lot more commands and options than I previously thought, so I needed a few more days.

If you can spare time Monday or Tuesday to do the PR review that would be great. You’ll need to review the Installation Guide and User Guide. The netlify link is here:
https://609876518bc99f8f7bb90640--overture.netlify.app/documentation/score/

@samrichca I've tagged you for review as usual just to check for conflicts. After I make the final updates from Jaser's review, I'll ask you to do a deploy later this week.

Thanks both!!

Copy link

@jaserud jaserud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lots of good work here. Great to see better arranged version of my google doc score-server knowledge dump 😛. I have just a few point that might be worth a look.

@b-f-chan b-f-chan merged commit de107de into develop May 13, 2021
@samrichca samrichca deleted the score_doc_revamp branch May 17, 2021 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants