New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Score doc revamp #154
Merged
Merged
Score doc revamp #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samrichca
approved these changes
May 11, 2021
jaserud
reviewed
May 11, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lots of good work here. Great to see better arranged version of my google doc score-server knowledge dump 😛. I have just a few point that might be worth a look.
markdown/documentation/score/installation/configuration/profiles.md
Outdated
Show resolved
Hide resolved
markdown/documentation/score/installation/configuration/object-storage.md
Outdated
Show resolved
Hide resolved
markdown/documentation/score/installation/configuration/object-storage.md
Show resolved
Hide resolved
jaserud
approved these changes
May 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @jaserud, I'm really sorry for the delay, but here's the final Score docs for review. I dug into the Score code and there were a lot more commands and options than I previously thought, so I needed a few more days.
If you can spare time Monday or Tuesday to do the PR review that would be great. You’ll need to review the Installation Guide and User Guide. The netlify link is here:
https://609876518bc99f8f7bb90640--overture.netlify.app/documentation/score/
@samrichca I've tagged you for review as usual just to check for conflicts. After I make the final updates from Jaser's review, I'll ask you to do a deploy later this week.
Thanks both!!