Skip to content

Added a couple new render mode primitives #706

Closed
wants to merge 7 commits into from

4 participants

@interfect

There's now "Exposed", which can be used to include or exclude exposed blocks, and "NoFluids", which can be used to exclude water and lava from a render.

@JonnyJD JonnyJD and 1 other commented on an outdated diff Apr 25, 2012
CONTRIBUTORS.rst
@@ -69,6 +69,7 @@ feature.
* Ryan McCue <ryanmccue@cubegames.net>
* Zach McCullough <nosrepa@gmail.com>
* Mike <mike@snowcrash.ca>
+ * Adam Novak <interfect@gmail.com>
@JonnyJD
JonnyJD added a note Apr 25, 2012

That should go one line further down, I guess.

@interfect
interfect added a note Apr 25, 2012

Should be fixed now,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@eminence
Minecraft Overviewer member

Hi. Thanks for this pull request. While we review this, a few things:

1) Could you rebase so there isn't a merge commit in this pull request? Let us know if you're not sure how to do that. (Also, it's recommended to submit pull requests from feature branches, not from your master branch).
2) Could you comment on why these are useful? What's the usecase?

@agrif, if you've got some spare cycles, mind having a quick look at this?

@agrif
Minecraft Overviewer member
agrif commented Apr 26, 2012

@eminence code looks fine to me.

I am curious to know what use case there is for the "exposed" primitive; at first glance I think it should just be merged into Base(), but I'm probably missing something.

@interfect

I have no idea how to rebase this, I'm not very good at Git. Sorry! Also, my branch was really just for the development of this feature.

These are both meant to be used with a mostly-transparent texture pack, like Strongestcraft. The NoFluids primitive is to filter out fluids so you can see anything underground, and the Exposed primitive can be used if you only want to reveal to your players ores that are already exposed (and that they could already know about by walking past them). It could also be inverted for a cool cutaway view.

@agrif
Minecraft Overviewer member
agrif commented May 6, 2012

I've just merged this into the devel branch, which is due to be merged into master eventually.

@agrif agrif closed this May 6, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.