From 8ea7019d7c925a2799933e1424efc21ad7515b7d Mon Sep 17 00:00:00 2001 From: rfougier Date: Wed, 27 Jun 2018 09:14:24 -0400 Subject: [PATCH] refactor(oui-header-tabs): fix BEM naming --- .../oui-header-tabs/src/header-tabs-dropdown.component.js | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/packages/oui-header-tabs/src/header-tabs-dropdown.component.js b/packages/oui-header-tabs/src/header-tabs-dropdown.component.js index 4a780f8f..8679926b 100644 --- a/packages/oui-header-tabs/src/header-tabs-dropdown.component.js +++ b/packages/oui-header-tabs/src/header-tabs-dropdown.component.js @@ -1,6 +1,7 @@ import template from "./header-tabs-dropdown.html"; const itemClass = "oui-header-tabs__item"; +const itemActiveClass = `${itemClass}_active`; const dropDownClass = `${itemClass}_dropdown`; export default { @@ -22,11 +23,11 @@ export default { .addClass(`${itemClass} ${dropDownClass}`) .attr("role", "listitem"); - this.$scope.$watch(() => !!this.$element[0].querySelector(`.${itemClass}_active`), hasActive => { + this.$scope.$watch(() => !!this.$element[0].querySelector(`.${itemActiveClass}`), hasActive => { if (hasActive) { - this.$element.addClass(`${dropDownClass}_active`); + this.$element.addClass(itemActiveClass); } else { - this.$element.removeClass(`${dropDownClass}_active`); + this.$element.removeClass(itemActiveClass); } }); });