From 26fa02f61b18bbdf8c573d89e2c8991d1a410c3f Mon Sep 17 00:00:00 2001 From: Axel Peter Date: Thu, 21 Feb 2019 15:39:56 +0100 Subject: [PATCH 1/2] fix: fix popper.js modifiers --- packages/oui-dropdown/src/dropdown.controller.js | 14 +++++++++++++- packages/oui-popover/src/popover.controller.js | 9 ++++++++- 2 files changed, 21 insertions(+), 2 deletions(-) diff --git a/packages/oui-dropdown/src/dropdown.controller.js b/packages/oui-dropdown/src/dropdown.controller.js index efef02c8..522ac5e2 100644 --- a/packages/oui-dropdown/src/dropdown.controller.js +++ b/packages/oui-dropdown/src/dropdown.controller.js @@ -145,7 +145,19 @@ export default class { this.popperElement.style.minWidth = `${this.getTriggerWidth()}px`; this.popper = new Popper(this.triggerElement, this.popperElement, { - placement + placement, + modifiers: { + flip: { + boundariesElement: "viewport" + }, + keepTogether: { + enabled: true + }, + preventOverflow: { + boundariesElement: "viewport", + escapeWithReference: true + } + } }); } diff --git a/packages/oui-popover/src/popover.controller.js b/packages/oui-popover/src/popover.controller.js index 9d7230e5..59ee895d 100644 --- a/packages/oui-popover/src/popover.controller.js +++ b/packages/oui-popover/src/popover.controller.js @@ -144,8 +144,15 @@ export default class PopoverController { this.popper = new Popper(this.triggerElement, this.popperElement, { placement: this.placement, modifiers: { + flip: { + boundariesElement: "viewport" + }, + keepTogether: { + enabled: true + }, preventOverflow: { - boundariesElement: this.$document[0].body + boundariesElement: "viewport", + escapeWithReference: true } } }); From e1d600cec86c591b557f27238b6c97bef0b0d501 Mon Sep 17 00:00:00 2001 From: Axel Peter Date: Thu, 21 Feb 2019 16:10:43 +0100 Subject: [PATCH 2/2] fix(oui-criteria): fix dropdown alignment --- packages/oui-criteria/src/adder/criteria-adder.html | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/oui-criteria/src/adder/criteria-adder.html b/packages/oui-criteria/src/adder/criteria-adder.html index 0cd27e80..16d60edb 100644 --- a/packages/oui-criteria/src/adder/criteria-adder.html +++ b/packages/oui-criteria/src/adder/criteria-adder.html @@ -1,4 +1,4 @@ - +