From 0d86c4bf7ced33ed0382badae7a5f711e8869dd9 Mon Sep 17 00:00:00 2001
From: varun257 <varun257@gmail.com>
Date: Thu, 28 Feb 2019 17:14:37 +0530
Subject: [PATCH 1/2] feat(oui-header-tabs): add on click events

add on-click event for header-tabs-item
add on-next-slide event oui-slideshow

resolves MBE-283, MBE-284
---
 packages/oui-header-tabs/README.md                         | 1 +
 packages/oui-header-tabs/src/header-tabs-item.component.js | 3 ++-
 packages/oui-header-tabs/src/header-tabs-item.html         | 4 +++-
 packages/oui-slideshow/README.md                           | 1 +
 packages/oui-slideshow/src/slideshow.component.js          | 3 ++-
 packages/oui-slideshow/src/slideshow.controller.js         | 1 +
 6 files changed, 10 insertions(+), 3 deletions(-)

diff --git a/packages/oui-header-tabs/README.md b/packages/oui-header-tabs/README.md
index 5ce82047..be233bbc 100644
--- a/packages/oui-header-tabs/README.md
+++ b/packages/oui-header-tabs/README.md
@@ -97,6 +97,7 @@
 | `active`      | boolean   | <?        | no                | `true`, `false`   | `false`   | manual active flag
 | `disabled`    | boolean   | <?        | yes               | `true`, `false`   | `false`   | disabled flag
 | `external`    | boolean   | <?        | yes               | `true`, `false`   | `false`   | external link flag
+| `on-click`    | function  | &         | no                | n/a               | n/a       | handler triggered when clicked
 
 **Note**: `ui-router` is needed for the attributes `state` and `state-params`.
 
diff --git a/packages/oui-header-tabs/src/header-tabs-item.component.js b/packages/oui-header-tabs/src/header-tabs-item.component.js
index 5e14b3ab..af2cb028 100644
--- a/packages/oui-header-tabs/src/header-tabs-item.component.js
+++ b/packages/oui-header-tabs/src/header-tabs-item.component.js
@@ -11,6 +11,7 @@ export default {
         stateParams: "<?",
         external: "<?",
         active: "<?",
-        disabled: "<?"
+        disabled: "<?",
+        onClick: "&"
     }
 };
diff --git a/packages/oui-header-tabs/src/header-tabs-item.html b/packages/oui-header-tabs/src/header-tabs-item.html
index fa87aea6..ac1946e8 100644
--- a/packages/oui-header-tabs/src/header-tabs-item.html
+++ b/packages/oui-header-tabs/src/header-tabs-item.html
@@ -4,13 +4,15 @@
     <a ng-attr-rel="{{::$ctrl.linkRel}}"
        ng-attr-target="{{::$ctrl.linkTarget}}"
        ng-href="{{::$ctrl.href}}"
-       ng-if="!!$ctrl.href && !$ctrl.disabled">
+       ng-if="!!$ctrl.href && !$ctrl.disabled"
+       ng-click="$ctrl.onClick()">
         <span ng-bind="::$ctrl.text"></span>
         <span class="oui-icon oui-icon-external_link" aria-hidden="true"
               ng-if="::$ctrl.external">
         </span>
     </a>
     <a ng-bind="::$ctrl.text"
+       ng-click="$ctrl.onClick()"
        ng-if="!!$ctrl.state && !$ctrl.disabled"
        ui-sref="{{::$ctrl.getFullSref()}}">
     </a>
diff --git a/packages/oui-slideshow/README.md b/packages/oui-slideshow/README.md
index 9a0a5c17..496b2cd2 100644
--- a/packages/oui-slideshow/README.md
+++ b/packages/oui-slideshow/README.md
@@ -88,6 +88,7 @@
 | `loading`     | boolean   | <?        | no                | `true`, `false`   | `false`   | display loader flag
 | `loop`        | boolean   | <?        | no                | `true`, `false`   | `false`   | whether the component should cycle continuously
 | `on-dismiss`  | function  | &         | no                | n/a               | n/a       | dismiss callback
+| `on-next`     | function  | &         | no                | n/a               | n/a       | handler triggered when on click of next slide
 
 ### oui-slideshow-panel
 
diff --git a/packages/oui-slideshow/src/slideshow.component.js b/packages/oui-slideshow/src/slideshow.component.js
index 401d3367..bb1046cd 100644
--- a/packages/oui-slideshow/src/slideshow.component.js
+++ b/packages/oui-slideshow/src/slideshow.component.js
@@ -9,6 +9,7 @@ export default {
         onDismiss: "&",
         loading: "<?",
         loop: "<?",
-        theme: "@?"
+        theme: "@?",
+        onNext: "&"
     }
 };
diff --git a/packages/oui-slideshow/src/slideshow.controller.js b/packages/oui-slideshow/src/slideshow.controller.js
index ab99f162..f9cb3b89 100644
--- a/packages/oui-slideshow/src/slideshow.controller.js
+++ b/packages/oui-slideshow/src/slideshow.controller.js
@@ -76,6 +76,7 @@ export default class {
     next () {
         if (!this._isSliding) {
             this._slide(Direction.NEXT);
+            this.onNext({ index: this.currentIndex });
         }
     }
 

From 19960fa8955a44c07885171f1cdf48c7e61b8905 Mon Sep 17 00:00:00 2001
From: varun257 <varun257@gmail.com>
Date: Fri, 1 Mar 2019 12:15:50 +0530
Subject: [PATCH 2/2] feat(oui-header-tabs): add on click events

add on-click event for header-tabs-item
add test case and example

resolves MBE-283, MBE-284
---
 packages/oui-header-tabs/README.md               | 15 ++++++++++++++-
 packages/oui-header-tabs/src/index.spec.js       | 16 ++++++++++++++++
 packages/oui-slideshow/README.md                 |  1 -
 .../oui-slideshow/src/slideshow.component.js     |  3 +--
 .../oui-slideshow/src/slideshow.controller.js    |  1 -
 5 files changed, 31 insertions(+), 5 deletions(-)

diff --git a/packages/oui-header-tabs/README.md b/packages/oui-header-tabs/README.md
index be233bbc..48098a2f 100644
--- a/packages/oui-header-tabs/README.md
+++ b/packages/oui-header-tabs/README.md
@@ -84,6 +84,19 @@
 </oui-page-header>
 ```
 
+
+### With action click
+
+```html:preview
+<oui-header-tabs>
+    <oui-header-tabs-item text="Home" href="/#" on-click="$ctrl.onActionClick()"></oui-header-tabs-item>
+    <oui-header-tabs-item text="Page Header" href="/#!/oui-angular/page-header"></oui-header-tabs-item>
+    <oui-header-tabs-item text="Header Tabs" href="/#!/oui-angular/header-tabs" active></oui-header-tabs-item>
+    <oui-header-tabs-item text="Pagination" href="/#!/oui-angular/pagination"></oui-header-tabs-item>
+    <oui-header-tabs-item text="Datagrid" href="/#!/oui-angular/datagrid" on-click="$ctrl.onActionClick()"></oui-header-tabs-item>
+</oui-header-tabs>
+```
+
 ## API
 
 ### oui-header-tabs-item
@@ -97,7 +110,7 @@
 | `active`      | boolean   | <?        | no                | `true`, `false`   | `false`   | manual active flag
 | `disabled`    | boolean   | <?        | yes               | `true`, `false`   | `false`   | disabled flag
 | `external`    | boolean   | <?        | yes               | `true`, `false`   | `false`   | external link flag
-| `on-click`    | function  | &         | no                | n/a               | n/a       | handler triggered when clicked
+| `on-click`    | function  | &         | no                | n/a               | n/a       | click handler
 
 **Note**: `ui-router` is needed for the attributes `state` and `state-params`.
 
diff --git a/packages/oui-header-tabs/src/index.spec.js b/packages/oui-header-tabs/src/index.spec.js
index e74d02f5..311850e5 100644
--- a/packages/oui-header-tabs/src/index.spec.js
+++ b/packages/oui-header-tabs/src/index.spec.js
@@ -126,5 +126,21 @@ describe("ouiHeaderTabs", () => {
             expect($separator.hasClass("oui-dropdown-menu__divider")).toBe(true);
             expect($separator.attr("role")).toBe("separator");
         });
+
+        it("should call function of onClick attribute, when header tab item is clicked", () => {
+            const clickSpy = jasmine.createSpy("spy");
+            const element = TestUtils.compileTemplate(`
+                <oui-header-tabs>
+                    <oui-header-tabs-item text="Tab" href="/#" on-click="$ctrl.clickHandler()"></oui-header-tabs-item>
+                </oui-header-tabs>`, {
+                    clickHandler: clickSpy
+                }
+            );
+
+            const item = element[0].querySelector(".oui-header-tabs__item a");
+            angular.element(item).triggerHandler("click");
+            expect(clickSpy).toHaveBeenCalled();
+            expect(clickSpy.calls.count()).toEqual(1);
+        });
     });
 });
diff --git a/packages/oui-slideshow/README.md b/packages/oui-slideshow/README.md
index 496b2cd2..9a0a5c17 100644
--- a/packages/oui-slideshow/README.md
+++ b/packages/oui-slideshow/README.md
@@ -88,7 +88,6 @@
 | `loading`     | boolean   | <?        | no                | `true`, `false`   | `false`   | display loader flag
 | `loop`        | boolean   | <?        | no                | `true`, `false`   | `false`   | whether the component should cycle continuously
 | `on-dismiss`  | function  | &         | no                | n/a               | n/a       | dismiss callback
-| `on-next`     | function  | &         | no                | n/a               | n/a       | handler triggered when on click of next slide
 
 ### oui-slideshow-panel
 
diff --git a/packages/oui-slideshow/src/slideshow.component.js b/packages/oui-slideshow/src/slideshow.component.js
index bb1046cd..401d3367 100644
--- a/packages/oui-slideshow/src/slideshow.component.js
+++ b/packages/oui-slideshow/src/slideshow.component.js
@@ -9,7 +9,6 @@ export default {
         onDismiss: "&",
         loading: "<?",
         loop: "<?",
-        theme: "@?",
-        onNext: "&"
+        theme: "@?"
     }
 };
diff --git a/packages/oui-slideshow/src/slideshow.controller.js b/packages/oui-slideshow/src/slideshow.controller.js
index f9cb3b89..ab99f162 100644
--- a/packages/oui-slideshow/src/slideshow.controller.js
+++ b/packages/oui-slideshow/src/slideshow.controller.js
@@ -76,7 +76,6 @@ export default class {
     next () {
         if (!this._isSliding) {
             this._slide(Direction.NEXT);
-            this.onNext({ index: this.currentIndex });
         }
     }