From 3057d41ab4e7fc430697ece9525a6d65900d62ef Mon Sep 17 00:00:00 2001
From: Jean-Daniel Pearson <1476965+JDownloader@users.noreply.github.com>
Date: Mon, 22 Jan 2018 16:59:49 -0500
Subject: [PATCH 1/2] :docs: docs(datagrid): improve datagrid documentation

---
 packages/oui-datagrid/README.md | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/packages/oui-datagrid/README.md b/packages/oui-datagrid/README.md
index fbc511b3..b1044d4e 100644
--- a/packages/oui-datagrid/README.md
+++ b/packages/oui-datagrid/README.md
@@ -245,7 +245,7 @@ You can use `row-loader`. It take the current row as argument and must return a
 | Attribute         | Type            | Binding | One-time binding | Values                    | Default             | Description                                       |
 | ----              | ----            | ----    | ----             | ----                      | ----                | ----                                              |
 | `page-size`       | number          | @?      |                  |                           | 25                  | maximum number of rows to show on each pages      |
-| `rows`            | string          | <?      | yes              |                           |                     | rows to show                                      |
+| `rows`            | array<object>   | <?      | yes              |                           |                     | rows to show                                      |
 | `rows-loader`     | function        | &?      | yes              |                           |                     | gets all rows (returns a promise with all rows)   |
 | `row-loader`      | function        | &?      | yes              |                           |                     | gets row details (returns a promise with details) |
 
@@ -258,6 +258,13 @@ You can use `row-loader`. It take the current row as argument and must return a
 | `property`        | string          | N/A     | yes              |                           |                        | property path used to get value from value  |
 | `sortable`        | string          | N/A     | yes              | `asc`, `desc`             | `asc` on `sortable=""` | makes a column sortable and gives the order |
 
+### rows-loader promise response
+
+| Attribute         | Type            | Binding | One-time binding | Values                    | Default             | Description                                                                                  |
+| ----              | ----            | ----    | ----             | ----                      | ----                | ----                                                                                         |
+| `data`            | array<object>   | <?      | yes              |                           |                     | rows to show                                                                                 |
+| `meta`            | object          | N/A     | yes              |                           |                     | an object containing pagination information {currentOffset, pageCount, totalCount, pageSize} |
+
 ### oui-action-menu
 
 Can be used as a column and will be sticked on side on smaller devices. Documentation about `oui-action-menu` can be found [here](#!/oui-angular/action-menu).

From 55e2f98977a1d3561b7209012b40034ab1c98441 Mon Sep 17 00:00:00 2001
From: Jean-Daniel Pearson <1476965+JDownloader@users.noreply.github.com>
Date: Tue, 23 Jan 2018 14:30:48 -0500
Subject: [PATCH 2/2] :docs: docs(datagrid):  doc minor correction

---
 packages/oui-datagrid/README.md | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/packages/oui-datagrid/README.md b/packages/oui-datagrid/README.md
index b1044d4e..5d9d1bd8 100644
--- a/packages/oui-datagrid/README.md
+++ b/packages/oui-datagrid/README.md
@@ -263,7 +263,7 @@ You can use `row-loader`. It take the current row as argument and must return a
 | Attribute         | Type            | Binding | One-time binding | Values                    | Default             | Description                                                                                  |
 | ----              | ----            | ----    | ----             | ----                      | ----                | ----                                                                                         |
 | `data`            | array<object>   | <?      | yes              |                           |                     | rows to show                                                                                 |
-| `meta`            | object          | N/A     | yes              |                           |                     | an object containing pagination information {currentOffset, pageCount, totalCount, pageSize} |
+| `meta`            | object          | N/A     | yes              |                           |                     | an object containing pagination information { totalCount: X } |
 
 ### oui-action-menu