fix(api): project permission at creation (#4691)

close #4678 Signed-off-by: Yvonnick Esnault <yvonnick.esnault@corp.ovh.com>
ovh · Oct 24, 2019 · e698292 · e698292
1 parent 396580d
commit e698292
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/engine/api/project.go b/engine/api/project.go
@@ -514,16 +514,16 @@ func (api *API) addProjectHandler() service.Handler {
 		if err := tx.Commit(); err != nil {
 			return sdk.WrapError(err, "Cannot commit transaction")
 		}
-		p.Permission = permission.PermissionReadWriteExecute
 
 		event.PublishAddProject(p, deprecatedGetUser(ctx))
 
 		proj, errL := project.Load(api.mustDB(), api.Cache, p.Key, deprecatedGetUser(ctx), project.LoadOptions.WithLabels, project.LoadOptions.WithWorkflowNames,
-			project.LoadOptions.WithFavorites, project.LoadOptions.WithKeys, project.LoadOptions.WithPermission,
+			project.LoadOptions.WithFavorites, project.LoadOptions.WithKeys,
 			project.LoadOptions.WithIntegrations, project.LoadOptions.WithVariables)
 		if errL != nil {
 			return sdk.WrapError(errL, "Cannot load project %s", p.Key)
 		}
+		proj.Permission = permission.PermissionReadWriteExecute
 
 		return service.WriteJSON(w, *proj, http.StatusCreated)
 	}

diff --git a/engine/api/project_test.go b/engine/api/project_test.go
@@ -124,6 +124,7 @@ func Test_addProjectHandler(t *testing.T) {
 	projCreated := sdk.Project{}
 	test.NoError(t, json.Unmarshal(w.Body.Bytes(), &projCreated))
 	assert.Equal(t, proj.Key, projCreated.Key)
+	assert.Equal(t, 7, projCreated.Permission)
 
 	gr, err := group.LoadGroup(db, proj.Name)
 	assert.NotNil(t, gr)