Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: cdsctl workflow run send the wrong payload #4753

Closed
fsamin opened this issue Nov 8, 2019 · 0 comments · Fixed by #4755
Closed

fix: cdsctl workflow run send the wrong payload #4753

fsamin opened this issue Nov 8, 2019 · 0 comments · Fixed by #4755
Assignees
@bnjjj
Labels
bug cli

Comments

@fsamin
Copy link
Member

fsamin commented Nov 8, 2019

cds/cli/cdsctl/workflow_run.go

Line 109 in 075f55b

r, errP := repo.New(dir)

When running cdsctl workflow run, we send by default git.branch set to the current branch, even if the workflow concerned is not the same repository, or even if the workflow doens't have git.branch in its payload
@bnjjj bnjjj self-assigned this Nov 8, 2019
bnjjj added a commit that referenced this issue Nov 8, 2019
@bnjjj
fix(cdsctl): workflow run only send git.branch when needed #4753
b7439a0 
Signed-off-by: Benjamin Coenen <benjamin.coenen@corp.ovh.com>
@bnjjj bnjjj mentioned this issue Nov 8, 2019
Merged
sguiheux pushed a commit that referenced this issue Nov 12, 2019
@bnjjj @sguiheux
fix(cdsctl): workflow run only send git.branch when needed #4753 (#4755)
bb9af5e 
Signed-off-by: Benjamin Coenen <benjamin.coenen@corp.ovh.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bnjjj bnjjj

Labels
bug cli
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(cdsctl): workflow run only send git.branch when needed #4753 ovh/cds
2 participants
@fsamin @bnjjj