Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow user to restart only failed job #4972

Merged
merged 12 commits into from Feb 21, 2020
Merged

feat: allow user to restart only failed job #4972

merged 12 commits into from Feb 21, 2020

Conversation

sguiheux
Copy link
Collaborator

@sguiheux sguiheux commented Feb 11, 2020 •
edited

  1. Description
  2. Related issues
    close Re run only failed jobs #4813
  3. About tests
  4. Mentions

@ovh/cds

@ovh-cds
Copy link
Collaborator

ovh-cds commented Feb 11, 2020

CDS Report build-all-cds#12379.0 ✘

  • Build
    • Build and Package All ✔
    • Build Debpacker ✔
    • Build OS-Ansible-Inventory ✔
    • Build SMTPMock ✔
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✘
    • Test SDK ✔
    • Test SDK Rust ✔
    • Test UI ✔

yesnault
yesnault requested changes Feb 11, 2020
View reviewed changes
engine/api/workflow/execute_node_run.go Outdated Show resolved Hide resolved
sguiheux and others added 3 commits February 11, 2020 16:00
@ovh-cds
Copy link
Collaborator

ovh-cds commented Feb 11, 2020

CDS Report build-all-cds#12382.0 ✘

  • Build
    • Build and Package All ✔
    • Build Debpacker ✔
    • Build OS-Ansible-Inventory ✔
    • Build SMTPMock ✔
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✘
    • Test SDK ✔
    • Test SDK Rust ✔
    • Test UI ✔

@sguiheux sguiheux requested a review from bnjjj February 13, 2020 07:20
fsamin
fsamin requested changes Feb 13, 2020
View reviewed changes
Copy link
Member

@fsamin fsamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add an integration tests with resync, and with onlyFailed ?

@sguiheux sguiheux requested a review from fsamin February 14, 2020 09:49
@sguiheux sguiheux mentioned this pull request Feb 14, 2020
Closed
@ovh-cds
Copy link
Collaborator

ovh-cds commented Feb 20, 2020

CDS Report build-all-cds#12459.0 ✘

  • Build
    • Build and Package All ✔
    • Build Debpacker ✔
    • Build OS-Ansible-Inventory ✔
    • Build SMTPMock ✔
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✘
    • Test SDK ✔
    • Test SDK Rust ✔
    • Test UI ✔

fsamin
fsamin requested changes Feb 20, 2020
View reviewed changes
engine/api/workflow/dao_run.go Outdated Show resolved Hide resolved
engine/api/workflow_run_test.go Outdated Show resolved Hide resolved
@ovh-cds
Copy link
Collaborator

ovh-cds commented Feb 20, 2020

CDS Report build-all-cds#12462.0 ✘

  • Build
    • Build and Package All ✔
    • Build Debpacker ✔
    • Build OS-Ansible-Inventory ✔
    • Build SMTPMock ✔
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✔
    • Test SDK ✔
    • Test SDK Rust ✔
    • Test UI ✔
  • Package
    • Docker ✔
    • Docs ✔
  • Integration
    • Docker Compose Tests ✔
    • Helm Tests -
    • Standalone Tests ✘

@ovh-cds
Copy link
Collaborator

ovh-cds commented Feb 20, 2020

CDS Report build-all-cds#12462.1 ✘

  • Build
    • Build and Package All ✔
    • Build Debpacker ✘
    • Build OS-Ansible-Inventory ✔
    • Build SMTPMock ✔
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✔
    • Test SDK ✔
    • Test SDK Rust ✔
    • Test UI ✔

@ovh-cds
Copy link
Collaborator

ovh-cds commented Feb 20, 2020

CDS Report build-all-cds#12462.2 ✘

  • Build
    • Build and Package All ✔
    • Build Debpacker ✔
    • Build OS-Ansible-Inventory ✔
    • Build SMTPMock ✔
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✔
    • Test SDK ✔
    • Test SDK Rust ✔
    • Test UI ✔
  • Package
    • Docker ✔
    • Docs ✔
  • Integration
    • Docker Compose Tests ✔
    • Helm Tests -
    • Standalone Tests ✘

@ovh-cds
Copy link
Collaborator

ovh-cds commented Feb 20, 2020

CDS Report build-all-cds#12462.3 ✘

  • Build
    • Build and Package All ✔
    • Build Debpacker ✔
    • Build OS-Ansible-Inventory ✔
    • Build SMTPMock ✔
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✔
    • Test SDK ✔
    • Test SDK Rust ✔
    • Test UI ✔
  • Package
    • Docker ✔
    • Docs ✔
  • Integration
    • Docker Compose Tests ✔
    • Helm Tests -
    • Standalone Tests ✘

@ovh-cds
Copy link
Collaborator

ovh-cds commented Feb 20, 2020

CDS Report build-all-cds#12462.4 ✘

  • Build
    • Build and Package All ✔
    • Build Debpacker ✔
    • Build OS-Ansible-Inventory ✔
    • Build SMTPMock ✔
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✔
    • Test SDK ✔
    • Test SDK Rust ✔
    • Test UI ✔
  • Package
    • Docker ✔
    • Docs ✔
  • Integration
    • Docker Compose Tests ✔
    • Helm Tests -
    • Standalone Tests ✘

@ovh-cds
Copy link
Collaborator

ovh-cds commented Feb 21, 2020

CDS Report build-all-cds#12462.5 ✘

  • Build
    • Build and Package All ✔
    • Build Debpacker ✔
    • Build OS-Ansible-Inventory ✘
    • Build SMTPMock ✔
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✔
    • Test SDK ✔
    • Test SDK Rust ✔
    • Test UI ✔

@ovh-cds
Copy link
Collaborator

ovh-cds commented Feb 21, 2020

CDS Report build-all-cds#12462.6 ✘

  • Build
    • Build and Package All ✔
    • Build Debpacker ✔
    • Build OS-Ansible-Inventory ✔
    • Build SMTPMock ✔
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✔
    • Test SDK ✔
    • Test SDK Rust ✔
    • Test UI ✔
  • Package
    • Docker ✔
    • Docs ✔
  • Integration
    • Docker Compose Tests ✔
    • Helm Tests -
    • Standalone Tests ✘

@ovh-cds
Copy link
Collaborator

ovh-cds commented Feb 21, 2020

CDS Report build-all-cds#12462.7 ✘

  • Build
    • Build and Package All ✔
    • Build Debpacker ✔
    • Build OS-Ansible-Inventory ✔
    • Build SMTPMock ✔
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✔
    • Test SDK ✔
    • Test SDK Rust ✔
    • Test UI ✔
  • Package
    • Docker ✔
    • Docs ✔
  • Integration
    • Docker Compose Tests ✔
    • Helm Tests -
    • Standalone Tests ✘

@richardlt richardlt merged commit 8000d8e into master Feb 21, 2020
@sguiheux sguiheux deleted the restartOnlyFailed branch February 24, 2020 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yesnault yesnault yesnault approved these changes

@fsamin fsamin fsamin approved these changes

@richardlt richardlt richardlt approved these changes

@bnjjj bnjjj bnjjj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Re run only failed jobs
6 participants
@sguiheux @ovh-cds @yesnault @fsamin @richardlt @bnjjj