From 940674a833aa007959ac4ff97b9687cd5b246ffe Mon Sep 17 00:00:00 2001
From: Nicolas Pierre-charles <nicolas.pierre-charles.ext@corp.ovh.com>
Date: Thu, 25 Apr 2024 11:08:14 +0200
Subject: [PATCH] fix(vrack-services): fix error message not disappearing on
 overview page

ref: MANAGER-14189

Signed-off-by: Nicolas Pierre-charles <nicolas.pierre-charles.ext@corp.ovh.com>
---
 .../apps/vrack-services/src/utils/vs-utils.ts | 28 ++++++++-----------
 1 file changed, 11 insertions(+), 17 deletions(-)

diff --git a/packages/manager/apps/vrack-services/src/utils/vs-utils.ts b/packages/manager/apps/vrack-services/src/utils/vs-utils.ts
index 91be0657db8d..3b71383ab9c8 100644
--- a/packages/manager/apps/vrack-services/src/utils/vs-utils.ts
+++ b/packages/manager/apps/vrack-services/src/utils/vs-utils.ts
@@ -89,12 +89,7 @@ export const useUpdateVrackServices = ({
   const [isErrorVisible, setIsErrorVisible] = React.useState(false);
   const queryClient = useQueryClient();
 
-  const {
-    mutateAsync: updateVS,
-    isPending,
-    isError,
-    error: updateError,
-  } = useMutation<
+  const { mutateAsync: updateVS, isPending, error: updateError } = useMutation<
     ApiResponse<VrackServices>,
     ApiError,
     UpdateVrackServicesParams
@@ -105,9 +100,11 @@ export const useUpdateVrackServices = ({
       queryClient.invalidateQueries({
         queryKey: getVrackServicesResourceListQueryKey,
       });
-      queryClient.invalidateQueries({
-        queryKey: getVrackServicesResourceQueryKey(result.data?.id || key),
-      });
+      if (result) {
+        queryClient.invalidateQueries({
+          queryKey: getVrackServicesResourceQueryKey(result.data?.id || key),
+        });
+      }
     },
     onSuccess: (result: ApiResponse<VrackServices>) => {
       queryClient.setQueryData(
@@ -139,19 +136,16 @@ export const useUpdateVrackServices = ({
       }, updateTriggerDelay);
       onSuccess?.(result);
     },
-    onError,
-  });
-
-  React.useEffect(() => {
-    if (isError) {
+    onError: (result) => {
       setIsErrorVisible(true);
-    }
-  }, [isError]);
+      onError?.(result);
+    },
+  });
 
   return {
     updateVS,
     isPending,
-    isErrorVisible,
+    isErrorVisible: updateError && isErrorVisible,
     hideError: () => setIsErrorVisible(false),
     updateError,
   };