Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/uxct 438 otb update statistics endpoint #6342

Merged
merged 3 commits into from Jan 31, 2022
Merged

Feat/uxct 438 otb update statistics endpoint #6342

merged 3 commits into from Jan 31, 2022

Conversation

Steffy29
Copy link
Contributor

Question Answer
Branch? develop
Bug fix? no
New feature? yes
Breaking change? no
Tickets Fix #UXCT-438
License BSD 3-Clause
  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
  • Only FR translations have been updated
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
  • Breaking change is mentioned in relevant commits

Description

Rework on statistics display to use new statistics API v6 endpoint.

Stephanie Moallic added 2 commits January 21, 2022 10:54
feat(overthebox.details): use the new endpoint for statistics
c9f9e31 
Signed-off-by: Stephanie Moallic <stephanie.moallic@corp.ovh.com>
feat(overthebox.details): change endpoint to retrieve statistics
0211396 
Signed-off-by: Stephanie Moallic <stephanie.moallic@corp.ovh.com>
@Steffy29 Steffy29 self-assigned this Jan 21, 2022
@Steffy29 Steffy29 requested a review from a team as a code owner January 21, 2022 15:28
feat(overthebox.details): use constant for rate conversion
bba53d5 
Signed-off-by: Stephanie Moallic <stephanie.moallic@corp.ovh.com>
@sonarcloud
Copy link

sonarcloud bot commented Jan 24, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@antleblanc antleblanc added question Further information is requested and removed question Further information is requested labels Jan 31, 2022
@antleblanc antleblanc merged commit 867322a into develop Jan 31, 2022
@antleblanc antleblanc deleted the feat/UXCT-438-otb-update-statistics branch January 31, 2022 09:54
@antleblanc antleblanc mentioned this pull request Jan 31, 2022
Merged
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frenautvh frenautvh frenautvh left review comments

@JeremyDec JeremyDec JeremyDec left review comments

@antleblanc antleblanc antleblanc approved these changes

@mohammed-zahaf mohammed-zahaf mohammed-zahaf approved these changes

@varun257 varun257 Awaiting requested review from varun257 varun257 is a code owner automatically assigned from ovh/team-manager-dev

@ghyenne ghyenne Awaiting requested review from ghyenne ghyenne is a code owner automatically assigned from ovh/team-manager-dev

Assignees

@Steffy29 Steffy29

Labels
feature New feature quality check: ok universe-telecom
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Steffy29 @antleblanc @mohammed-zahaf @frenautvh @JeremyDec