Skip to content

Php8.4 #155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 2, 2025
Merged

Php8.4 #155

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ jobs:
strategy:
fail-fast: false
matrix:
php-version: [ '7.4', '8.0', '8.1', '8.2' ]
php-version: [ '8.1', '8.2', '8.3', '8.4' ]
steps:
- uses: "actions/checkout@v2"
- uses: "shivammathur/setup-php@v2"
Expand Down Expand Up @@ -81,7 +81,7 @@ jobs:
max-parallel: 1
fail-fast: false
matrix:
php-version: [ '7.4', '8.0', '8.1', '8.2' ]
php-version: [ '8.1', '8.2', '8.3', '8.4' ]
steps:
- uses: "actions/checkout@v2"
- uses: "shivammathur/setup-php@v2"
Expand All @@ -94,4 +94,4 @@ jobs:
run: "mkdir -p build/logs"
- uses: "ramsey/composer-install@v2"
- name: "Run unit tests"
run: "composer phpunit"
run: "composer phpunit -- --no-coverage"
2 changes: 1 addition & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
"require-dev": {
"php-parallel-lint/php-parallel-lint": "^1.3.1",
"phpdocumentor/shim": "^3",
"phpunit/phpunit": "^9.6",
"phpunit/phpunit": "^10.5",
"squizlabs/php_codesniffer": "^3.6"
},
"autoload": {
Expand Down
59 changes: 32 additions & 27 deletions phpunit.xml.dist
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,31 +1,36 @@
<?xml version="1.0" encoding="UTF-8"?>
<phpunit
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:noNamespaceSchemaLocation="https://schema.phpunit.de/10.5/phpunit.xsd"
bootstrap="./vendor/autoload.php"
colors="true"
convertErrorsToExceptions="true"
convertWarningsToExceptions="true"
convertNoticesToExceptions="true"
convertDeprecationsToExceptions="true"
>
<testsuites>
<testsuite name="all">
<directory>./tests</directory>
</testsuite>
</testsuites>

<coverage>
<include>
<directory suffix=".php">src/</directory>
</include>

<report>
<clover outputFile="build/logs/clover.xml" />
<html outputDirectory="build/coverage" />
<text outputFile="php://stdout" />
</report>
</coverage>

<logging>
<junit outputFile="build/report.junit.xml"/>
</logging>
</phpunit>
cacheDirectory=".phpunit.cache"
failOnEmptyTestSuite="true"
failOnWarning="true"
failOnRisky="true"
failOnDeprecation="true"
failOnPhpunitDeprecation="true"
failOnNotice="true"
failOnIncomplete="true"
>
<testsuites>
<testsuite name="all">
<directory>./tests</directory>
</testsuite>
</testsuites>
<coverage>
<report>
<clover outputFile="build/logs/clover.xml"/>
<html outputDirectory="build/coverage"/>
<text outputFile="php://stdout"/>
</report>
</coverage>
<logging>
<junit outputFile="build/report.junit.xml"/>
</logging>
<source>
<include>
<directory suffix=".php">src/</directory>
</include>
</source>
</phpunit>
2 changes: 1 addition & 1 deletion src/Api.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ public function __construct(
$application_secret,
$api_endpoint,
$consumer_key = null,
Client $http_client = null
?Client $http_client = null
) {
if (!isset($api_endpoint)) {
throw new Exceptions\InvalidParameterException("Endpoint parameter is empty");
Expand Down
Loading