New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ship as part of GitLab #265

Closed
dosire opened this Issue Feb 23, 2016 · 9 comments

Comments

Projects
None yet
4 participants
@dosire

dosire commented Feb 23, 2016

Hi Buu,

Are you open to having us ship octotree as part of GitLab? This would help with usage:

  1. Users no longer have to install anything.
  2. On-premises users (the majority of GitLab users) don't have to configure it https://github.com/buunguyen/octotree#enterprise-urls
  3. We might add support for recent versions of Internet Explorer

Obviously we would do all the work of integrating this and we would contribute back any fixes that are relevant.

What do you think? Please let me know if you prefer to talk about this.

@buunguyen

This comment has been minimized.

Show comment
Hide comment
@buunguyen

buunguyen Feb 24, 2016

Collaborator

@dosire it's probably best for your users. Just to be clear, what do you mean by shipping Octotree as part of GitLab, are you going to implement the tree from scratch or taking bits and pieces from Octotree?

Collaborator

buunguyen commented Feb 24, 2016

@dosire it's probably best for your users. Just to be clear, what do you mean by shipping Octotree as part of GitLab, are you going to implement the tree from scratch or taking bits and pieces from Octotree?

@dosire

This comment has been minimized.

Show comment
Hide comment
@dosire

dosire Feb 24, 2016

@buunguyen I'm thinking about reusing as much of Octotree as we can and contributing back any fixes we make in its code.

dosire commented Feb 24, 2016

@buunguyen I'm thinking about reusing as much of Octotree as we can and contributing back any fixes we make in its code.

@buunguyen

This comment has been minimized.

Show comment
Hide comment
@buunguyen

buunguyen Feb 25, 2016

Collaborator

Got that. Unless a change is non-GitLab specific, I don't think contributing back is necessary as there's no reason to keep GitLab support in Octotree if the feature is built-in. @crashbell and I myself spent many months working on and off to bring GitLab support to Octotree. It's a bit sad that we can't enjoy the fruit of our labor a bit longer ;). But I guess this is best for the community and I'm glad our work helps improve GitLab.

Collaborator

buunguyen commented Feb 25, 2016

Got that. Unless a change is non-GitLab specific, I don't think contributing back is necessary as there's no reason to keep GitLab support in Octotree if the feature is built-in. @crashbell and I myself spent many months working on and off to bring GitLab support to Octotree. It's a bit sad that we can't enjoy the fruit of our labor a bit longer ;). But I guess this is best for the community and I'm glad our work helps improve GitLab.

@dosire

This comment has been minimized.

Show comment
Hide comment
@dosire

dosire Feb 25, 2016

@buunguyen I agree that only generic changes would make sense to contribute back.

I'm sorry that integrating it would negate your and @crashbell's work on it. Obviously we really happy that there is support right now. And I'm not sure if and when we'll add support in GitLab itself, but I wanted your blessing before proceeding, thanks.

Can I make you both happy with some GitLab swag?

dosire commented Feb 25, 2016

@buunguyen I agree that only generic changes would make sense to contribute back.

I'm sorry that integrating it would negate your and @crashbell's work on it. Obviously we really happy that there is support right now. And I'm not sure if and when we'll add support in GitLab itself, but I wanted your blessing before proceeding, thanks.

Can I make you both happy with some GitLab swag?

@dosire

This comment has been minimized.

Show comment
Hide comment
@dosire

dosire commented Feb 25, 2016

Link back to GitLab issue https://gitlab.com/gitlab-org/gitlab-ce/issues/13723

@buunguyen

This comment has been minimized.

Show comment
Hide comment
@buunguyen

buunguyen Feb 25, 2016

Collaborator

@crashbell may chime in here but I don't think he would object. Please go ahead.

Collaborator

buunguyen commented Feb 25, 2016

@crashbell may chime in here but I don't think he would object. Please go ahead.

@buunguyen buunguyen closed this Feb 25, 2016

@dosire

This comment has been minimized.

Show comment
Hide comment
@dosire

dosire commented Feb 25, 2016

Thanks @buunguyen

@vindarel

This comment has been minimized.

Show comment
Hide comment
@vindarel

vindarel Jul 27, 2017

So, they are not shipping Octotree but they are integrating VSCode: https://gitlab.com/gitlab-org/gitlab-ce/issues/31890

Near the end of the first issue, we discover a similar project: https://github.com/git-toni/reposplit (Chrome only ATM, Gitlab support but no private Gitlab projects)

vindarel commented Jul 27, 2017

So, they are not shipping Octotree but they are integrating VSCode: https://gitlab.com/gitlab-org/gitlab-ce/issues/31890

Near the end of the first issue, we discover a similar project: https://github.com/git-toni/reposplit (Chrome only ATM, Gitlab support but no private Gitlab projects)

@leocaseiro

This comment has been minimized.

Show comment
Hide comment
@leocaseiro

leocaseiro Feb 5, 2018

Contributor

I've just found an extension working very well for gitlab (work for self hosted): https://chrome.google.com/webstore/detail/gitlab-code-view/gglalfcdiahpedikbmegmmkmpmajnpjj

Contributor

leocaseiro commented Feb 5, 2018

I've just found an extension working very well for gitlab (work for self hosted): https://chrome.google.com/webstore/detail/gitlab-code-view/gglalfcdiahpedikbmegmmkmpmajnpjj

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment