Remove metric ovs_vswitchd_dp_if due to high number of time series #3022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This metric produces a time series for each interface and this becomes problematic when the number of nodes in a cluster scales. For example, with a 50 node cluster and 200 pods per node, we are looking at 10000 time series. In order to protect the prometheus database, I want to remove this. Signed-off-by: Martin Kennelly <mkennell@redhat.com>
|
/retest |
|
/lgtm |
|
Girish is ok with removing these: https://ovn-org.slack.com/archives/C010SQ5FSNL/p1654786395218709?thread_ts=1654681114.584799&cid=C010SQ5FSNL |
|
/retest |
trozet
approved these changes
Jun 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This metric produces a time series for each interface and this
becomes problematic when the number of nodes in a cluster scales.
For example, with a 50 node cluster and 200 pods per node, we are
looking at 10000 time series.
In order to protect the prometheus database, I want to remove this.
Signed-off-by: Martin Kennelly mkennell@redhat.com
/cc @girishmg Are you ok with removing this?
@npinaeva @pperiyasamy