Reduce cardinality of OVS interface metrics #3032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinkennelly
force-pushed
the
rework_bridge_metrics
branch
from
9be1f22
to
20f5459
Compare
The cardinality of OVS interface metrics is undefined and will cause a huge increase in ovnkube-node memory and prom db size. This PR reduces this cardinality. It also removes interface metrics that have no obvious value but leaves the statistics and link_resets. Renames and reduces cardinality of: * ovs_vswitchd_interface_resets_total * ovs_vswitchd_interface_rx_dropped_total * ovs_vswitchd_interface_tx_dropped_total * ovs_vswitchd_interface_rx_errors_total * ovs_vswitchd_interface_tx_errors_total * ovs_vswitchd_interface_collisions_total Removes: * ovs_vswitchd_interface_driver_name * ovs_vswitchd_interface_driver_version * ovs_vswitchd_interface_firmware_version * ovs_vswitchd_interface_rx_packets * ovs_vswitchd_interface_tx_packets * ovs_vswitchd_interface_rx_bytes * ovs_vswitchd_interface_tx_bytes * ovs_vswitchd_interface_rx_frame_err * ovs_vswitchd_interface_rx_over_err * ovs_vswitchd_interface_rx_crc_err * ovs_vswitchd_interface_name * ovs_vswitchd_interface_duplex * ovs_vswitchd_interface_type * ovs_vswitchd_interface_admin_state * ovs_vswitchd_interface_link_state * ovs_vswitchd_interface_ifindex * ovs_vswitchd_interface_link_speed * ovs_vswitchd_interface_mtu * ovs_vswitchd_interface_ofport * ovs_vswitchd_interface_ingress_policing_burst * ovs_vswitchd_interface_ingress_policing_rate Signed-off-by: Martin Kennelly <mkennell@redhat.com>
martinkennelly
force-pushed
the
rework_bridge_metrics
branch
from
20f5459
to
cc90e34
Compare
|
Forced pushed to also remove: |
|
@dcbw When you have time, can you take a look at this to see if it negatively impacts the scale effort? |
|
/lgtm |
trozet
approved these changes
Jun 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduce cardinality of OVS interface metrics
The cardinality of OVS interface metrics is undefined and will
cause a huge increase in ovnkube-node memory and prom db size.
This PR reduces this cardinality.
It also removes interface metrics that have no obvious value but
leaves the statistics and link_resets.
Renames and reduces cardinality of:
Removes:
/cc @girishmg @npinaeva
I propose we use this instead of PR ( #3010 ) to fix ovnkube-nodes memory increase issue.