-
Notifications
You must be signed in to change notification settings - Fork 338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
multi-vtep: set ovn-encap-ip on OVS Port when adding it to br-int #4357
Conversation
#4177 is required for this feature. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me, just a minor nit.
/help |
Supported operations are /retest, /retest-failed, /cancel |
/retest-failed |
Oops, something went wrong:
|
/retest-failed |
Oops, something went wrong:
|
@girishmg did you get a chance to review this PR? |
On OVN Kubernetes side, no addtional configuration required to enable this feature. | ||
|
||
This feature depends on a specific underlay network setup; it cannot be turned off |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this be on
.
this feature cannot be turned on without an adequate underlay network configuration?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you are right.
done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your comments. I need to install spelling check in my editor.
On OVN Kubernetes side, no addtional configuration required to enable this feature. | ||
|
||
This feature depends on a specific underlay network setup; it cannot be turned off |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you are right.
done
To utilize multi-VTEP, the `external_ids:ovn-encap-ip` of the VF's OVS Port must be set. The VF's PCI device ID is then used to identify its corresponding PF, which in turn is used to look up the `external_ids:ovn-pf-encap-ip-mapping` to determine the encap-ip." Signed-off-by: Lei Huang <leih@nvidia.com>
Signed-off-by: Lei Huang <leih@nvidia.com>
…-encap-ip external_ids:ovn-encap-ip can be a list of IP address separted by comma, ovnkube-node should be able to startup without issue. Signed-off-by: Lei Huang <leih@nvidia.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing all my comments @l8huang !
LGTM
What this PR does and why is it needed
To utilize multi-VTEP, the
external_ids:ovn-encap-ip
of the VF's OVS Portmust be set. The VF's PCI device ID is then used to identify its corresponding
PF, which in turn is used to look up the
external_ids:ovn-pf-encap-ip-mapping
to determine the encap-ip."
Special notes for reviewers
doc is in progress
How to verify it
Unit test cases are added to verify ``external_ids:ovn-encap-ip` is set on OVS Port.