Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve readability of some functions by use for-comprehensions instead of nested `flatMap` #116

Merged
merged 4 commits into from Apr 10, 2019

Conversation

Projects
None yet
2 participants
@CremboC
Copy link
Contributor

commented Apr 3, 2019

This is a WIP until I do more of them. I'm trying a function-per-commit so it's easier to see changes.

CremboC added some commits Apr 1, 2019

@CremboC CremboC force-pushed the CremboC:for-comprehensions branch from f41809e to 60b3199 Apr 3, 2019

@CremboC CremboC marked this pull request as ready for review Apr 3, 2019

@CremboC CremboC force-pushed the CremboC:for-comprehensions branch from 60b3199 to d488ca5 Apr 4, 2019

@CremboC CremboC force-pushed the CremboC:for-comprehensions branch from d488ca5 to a8b8ebd Apr 4, 2019

@codecov

This comment has been minimized.

Copy link

commented Apr 4, 2019

Codecov Report

Merging #116 into master will increase coverage by 0.08%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #116      +/-   ##
=========================================
+ Coverage   93.12%   93.2%   +0.08%     
=========================================
  Files          40      40              
  Lines        1134    1134              
  Branches       67      73       +6     
=========================================
+ Hits         1056    1057       +1     
+ Misses         78      77       -1
Impacted Files Coverage Δ
src/main/scala/fs2/kafka/KafkaConsumer.scala 100% <100%> (+0.86%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1cab811...a8b8ebd. Read the comment docs.

@vlovgr

This comment has been minimized.

Copy link
Member

commented Apr 10, 2019

Thanks for this @CremboC!

@vlovgr vlovgr merged commit ac81470 into ovotech:master Apr 10, 2019

3 checks passed

codecov/patch 100% of diff hit (target 93.12%)
Details
codecov/project 93.2% (+0.08%) compared to 1cab811
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.