Permalink
Commits on Jun 14, 2012
  1. Use strong pointer to connectionError to prevent crash due to error b…

    Owain R Hunt committed Jun 14, 2012
    …eing prematurely released.
Commits on Jun 12, 2012
  1. Add -addIssue:toMilestone:… method.

    Owain R Hunt committed Jun 12, 2012
Commits on Jun 8, 2012
  1. Rewrite -close/reopenIssue: with correct format.

    Owain R Hunt committed Jun 8, 2012
    Note the paramsDictionary must be created outside of the invocation block, rather than being created in-place. This avoids a crash when -invoke is called on the invocation block, due to the dictionary being deallocated in the scope of the block. I think.
Commits on Jun 4, 2012
  1. Fixed crash caused by error handling in -invoke:…

    Owain R Hunt committed Jun 4, 2012
    Yes, again.
    
    Method signatures differ between invocations, but the last argument is always where the NSError lives. Previous implementation used '5' hard-coded as the argument for the error, but this (obviously) caused a crash when using a method signature that had the error at a different position.
    Now, we examine the method signature, find out the number of arguments, subtract 1 as it's zero-based, and put the error there.
  2. UAIssueAddRequest now a POST request. Oops.

    Owain R Hunt committed Jun 4, 2012
Commits on May 8, 2012
  1. Merge branch 'master' of github.com:owainhunt/UAGithubEngine

    Owain R Hunt committed May 8, 2012
    Conflicts:
    	README.md
  2. Update readme for clarity.

    Owain R Hunt committed May 8, 2012
  3. Update readme for clarity.

    Owain R Hunt committed May 8, 2012
Commits on May 7, 2012
  1. Error passing now *finally* works properly.

    Owain R Hunt committed May 7, 2012
    When creating an invocation, we have to create and assign both an NSError and a pointer to that NSError. We then send the address of the pointer to the error to the invocation by reference. Phew.
    (Also we now return after we call our failureBlock, otherwise we'll call the successBlock afterwards. And that ain't right.)
Commits on Apr 24, 2012
  1. Update README.md

    Owain R Hunt committed Apr 24, 2012
Commits on Apr 23, 2012
  1. Use correct format specifiers in strings.

    Owain R Hunt committed Apr 23, 2012
Commits on Apr 13, 2012
  1. Add open/closed issue state constants.

    Owain R Hunt committed Apr 13, 2012
  2. Add assigned/created/subscribed/mentioned issues methods.

    Owain R Hunt committed Apr 13, 2012
  3. Add request method that takes a pointer to an error instead of a fail…

    Owain R Hunt committed Apr 13, 2012
    …ure block.
Commits on Apr 12, 2012
  1. Update readme re framework.

    Owain R Hunt committed Apr 12, 2012
  2. Only import headers where we actually need to.

    Owain R Hunt committed Apr 12, 2012
  3. GDB -> LLDB for Test.

    Owain R Hunt committed Apr 12, 2012
  4. Reorganize folder structure and frameworkize.

    Owain R Hunt committed Apr 12, 2012
Commits on Apr 7, 2012
  1. Update readme code samples.

    Owain R Hunt committed Apr 7, 2012
  2. Update methods to use BooleanSuccessBlock and booleanSuccess: where n…

    Owain R Hunt committed Apr 7, 2012
    …eeded. Update readme to reflect new method signatures.
  3. Update methods to use BooleanSuccessBlock and booleanSuccess: where n…

    Owain R Hunt committed Apr 7, 2012
    …eeded.
  4. Add booleanSuccess: variant of -invoke:, for API calls that would ret…

    Owain R Hunt committed Apr 7, 2012
    …urn a YES or NO.
  5. Add BooleanSuccessBlock typedef.

    Owain R Hunt committed Apr 7, 2012
  6. Merge remote-tracking branch 'origin/errors'

    Owain R Hunt committed Apr 7, 2012
  7. Split issue requests into two separate methods.

    Owain R Hunt committed Apr 7, 2012
    switch statement in previous approach was causing exc_bad_access.
  8. Move NSInvocation category.

    Owain R Hunt committed Apr 7, 2012
  9. Update all methods to new body.

    Owain R Hunt committed Apr 7, 2012
    Replace returning id with calling invocation method. Also replace all uses of 'completion' with 'success'.
  10. Change all return types to void, all block types to UAGithubEngineSuc…

    Owain R Hunt committed Apr 7, 2012
    …cessBlock.
  11. Add typedef for success/failure blocks.

    Owain R Hunt committed Apr 7, 2012
Commits on Apr 6, 2012
  1. Rename successBlock_ to successBlock.

    Owain R Hunt committed Apr 6, 2012
    We don't do underscores.
  2. Trying out new approach on -respositoriesWithCompletion:failure:.

    Owain R Hunt committed Apr 6, 2012
    Now we tell UAGE to invoke the necessary API call and return the result.
    In -invoke, we create the NSError and id that get returned when the connection either succeeds or fails. This avoids replication of code all over the blinking place, and keeps each individual method down to a single line.
    (Also gives us the option to completely revise the way this works without having to change every single method again. Can just change the NSInvocation.)
  3. Add 'proper' error handling.

    Owain R Hunt committed Apr 6, 2012
    Error passed-by-reference to -sendRequest:. Now filled if an error is encountered before the end of the method. If an error is present, we return nil.