From db84d8cf771d39db578707cd03ec2b60f74c9785 Mon Sep 17 00:00:00 2001 From: Martin Vierula Date: Fri, 31 Mar 2023 08:27:35 -0700 Subject: [PATCH] Add some member varialbe inits in Transaction class --- CHANGES | 2 ++ src/transaction.cc | 12 ++++++------ 2 files changed, 8 insertions(+), 6 deletions(-) diff --git a/CHANGES b/CHANGES index 2bda1d867..220e091ea 100644 --- a/CHANGES +++ b/CHANGES @@ -1,6 +1,8 @@ v3.x.y - YYYY-MMM-DD (to be released) ------------------------------------- + - Add some member variable inits in Transaction class + [Issue #2886 - @GNU-Plus-Windows-User, @airween, @mdounin, @martinhsv] - Resolve memory leak on reload (bison-generated variable) [Issue #2876 - @martinhsv] - Support equals sign in XPath expressions diff --git a/src/transaction.cc b/src/transaction.cc index 1094ae56c..5038b0a0f 100644 --- a/src/transaction.cc +++ b/src/transaction.cc @@ -101,11 +101,11 @@ namespace modsecurity { */ Transaction::Transaction(ModSecurity *ms, RulesSet *rules, void *logCbData) : m_creationTimeStamp(utils::cpu_seconds()), - /* m_clientIpAddress(nullptr), */ + m_clientIpAddress(std::make_shared("")), m_httpVersion(""), - /* m_serverIpAddress(""), */ + m_serverIpAddress(std::make_shared("")), m_uri(""), - /* m_uri_no_query_string_decoded(""), */ + m_uri_no_query_string_decoded(std::make_shared("")), m_ARGScombinedSizeDouble(0), m_clientPort(0), m_highestSeverityAction(255), @@ -175,11 +175,11 @@ Transaction::Transaction(ModSecurity *ms, RulesSet *rules, void *logCbData) Transaction::Transaction(ModSecurity *ms, RulesSet *rules, char *id, void *logCbData) : m_creationTimeStamp(utils::cpu_seconds()), - /* m_clientIpAddress(""), */ + m_clientIpAddress(std::make_shared("")), m_httpVersion(""), - /* m_serverIpAddress(""), */ + m_serverIpAddress(std::make_shared("")), m_uri(""), - /* m_uri_no_query_string_decoded(""), */ + m_uri_no_query_string_decoded(std::make_shared("")), m_ARGScombinedSizeDouble(0), m_clientPort(0), m_highestSeverityAction(255),