Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PathID length calculation error #15

Closed
abiusx opened this issue Nov 28, 2013 · 4 comments
Closed

PathID length calculation error #15

abiusx opened this issue Nov 28, 2013 · 4 comments
Assignees
Milestone

Comments

@abiusx
Copy link
Contributor

abiusx commented Nov 28, 2013

The following code on line 120 of rbac.php:

    // $row_count = jf::SQL ( "SELECT count(*) FROM " . $this->tablePrefix() . $this->type());
    // $separator_count = --$row_count[0]['count(*)'];
    // $total_char_count = $query_char_count + $separator_count;

    // if ((int) $total_char_count >= 1024)
    //     throw new Exception ( "Path exceeds character count limit" );

Is invalid, because it counts for all the nodes that exist, and not just the ones that are being used! And always throws exceptions on big enough data sets. Should be fixed.

@jburns131
Copy link
Collaborator

Related to Issue #11

jburns131 added a commit that referenced this issue Feb 5, 2014
* Removed bad check for 1024 chars using sql statements.
* Added check for 1024 chars using '$Path' length.
@abiusx
Copy link
Contributor Author

abiusx commented Feb 6, 2014

Apparently SQLite has no limit on group_concat (this needs to be tested).
MySQL has a 1024 character limit, which can be bypassed with this:
SET SESSION group_concat_max_len = 1000000;

jburns131 added a commit that referenced this issue Feb 8, 2014
…t past the 1024 char limit of group_concat.

This commit addresses Issue #11 and Issue #15.
@jburns131
Copy link
Collaborator

This bug is being addressed in Issue #11. Closing this Issue.

@jburns131
Copy link
Collaborator

Unit Test completed.

@jburns131 jburns131 self-assigned this Feb 17, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants