Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incompatibility with Ubuntu 20.04 #146

Merged
merged 3 commits into from Dec 6, 2021

Conversation

srogatch
Copy link
Contributor

@srogatch srogatch commented Dec 1, 2021

Without this fix, the following error occurs on Ubuntu 20.04 with cmake 3.21.2:
Could NOT find OpenGL (missing: OPENGL_glx_LIBRARY)
See details in libigl/libigl#1731

@ingowald
Copy link
Contributor

ingowald commented Dec 4, 2021

Hey, Serge - thanks for that; I'll have to give it a closer look first because the "build your own glfw" fall back so far was only intended for Windows, so I've never even tried that under linux.

The "easier" solution you could do under linux is simply install the libglfw3-dev package, which not only pulls in all the other dependencies you listed above, and then just uses the system-glfw instead of building one on the fly (the "build on the fly" was mostly intended for windows, where installing library like glfw is .... well.... aeh.... well). That's also why this bug was never found, previously - apparently everybody under linux already had glfw installed, so the above doesn't trigger :-)

That said, I totally agree that owl should build properly without system-glfw, and the above looks like a perfect fix (I'll just have to make sure it also runs well on windows and other platforms). So thanks!

@srogatch
Copy link
Contributor Author

srogatch commented Dec 5, 2021

Hi Ingo! Thanks for looking into this. I think sudo apt-get install libglfw3-dev then should be among the build steps for OWL in the README.md file.

@ingowald ingowald merged commit fc956fc into owl-project:master Dec 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants