Support ffmpeg 6

[dumbasPL]

Share your bug report, feature request, or comment.

In ffmpeg version 5 the three distinct pixel formats seems to have been merged into one named just vaapi

The code currently forces the vaapi_vld pixel format that is no longer present in the latest version of ffmpeg

Here is a comparison of available pixel formats on ffmpeg 5.0.1 (from alpine 3.16) and 4.4.1 (from alpine 3.15).

$ docker run --rm -it alpine:latest sh -c "apk add ffmpeg > /dev/null && ffmpeg -pix_fmts | grep vaapi" 
ffmpeg version 5.0.1 Copyright (c) 2000-2022 the FFmpeg developers
  built with gcc 11.2.1 (Alpine 11.2.1_git20220219) 20220219
  configuration: --prefix=/usr --enable-avfilter --enable-gnutls --enable-gpl --enable-libass --enable-libmp3lame --enable-libpulse --enable-libvorbis --enable-libvpx --enable-libxvid --enable-libx264 --enable-libx265 --enable-libtheora --enable-libv4l2 --enable-libdav1d --enable-lto --enable-postproc --enable-pic --enable-pthreads --enable-shared --enable-libxcb --enable-librist --enable-libsrt --enable-libssh --enable-libvidstab --disable-stripping --disable-static --disable-librtmp --enable-libaom --enable-libopus --enable-libsoxr --enable-libwebp --enable-vaapi --enable-vdpau --enable-vulkan --enable-libdrm --disable-debug
  libavutil      57. 17.100 / 57. 17.100
  libavcodec     59. 18.100 / 59. 18.100
  libavformat    59. 16.100 / 59. 16.100
  libavdevice    59.  4.100 / 59.  4.100
  libavfilter     8. 24.100 /  8. 24.100
  libswscale      6.  4.100 /  6.  4.100
  libswresample   4.  3.100 /  4.  3.100
  libpostproc    56.  3.100 / 56.  3.100
..H.. vaapi                  0              0      0

$ docker run --rm -it alpine:3.15 sh -c "apk add ffmpeg > /dev/null && ffmpeg -pix_fmts | grep vaapi"
ffmpeg version 4.4.1 Copyright (c) 2000-2021 the FFmpeg developers
  built with gcc 10.3.1 (Alpine 10.3.1_git20211027) 20211027
  configuration: --prefix=/usr --enable-avresample --enable-avfilter --enable-gnutls --enable-gpl --enable-libass --enable-libmp3lame --enable-libvorbis --enable-libvpx --enable-libxvid --enable-libx264 --enable-libx265 --enable-libtheora --enable-libv4l2 --enable-libdav1d --enable-postproc --enable-pic --enable-pthreads --enable-shared --enable-libxcb --enable-libsrt --enable-libssh --enable-libvidstab --disable-stripping --disable-static --disable-librtmp --enable-libaom --enable-libopus --enable-libsoxr --enable-libwebp --enable-vaapi --enable-vdpau --enable-vulkan --disable-debug
  libavutil      56. 70.100 / 56. 70.100
  libavcodec     58.134.100 / 58.134.100
  libavformat    58. 76.100 / 58. 76.100
  libavdevice    58. 13.100 / 58. 13.100
  libavfilter     7.110.100 /  7.110.100
  libavresample   4.  0.  0 /  4.  0.  0
  libswscale      5.  9.100 /  5.  9.100
  libswresample   3.  9.100 /  3.  9.100
  libpostproc    55.  9.100 / 55.  9.100
..H.. vaapi_moco             0             0
..H.. vaapi_idct             0             0
..H.. vaapi_vld              0             0

[gabek]

Well that's unfortunate. We'll have to do version checking to switch between the two pixel format names, and parsing of ffmpeg's version string has been difficult in the past.

[dumbasPL]

How about checking available pix_fmts and picking one? Wouldn't that be more universal? I would assume parsing that would be even harder

[gabek]

• Test out of the box functionality with ffmpeg 5 (using x264)
• Test nvenc
• Test omx (Raspberry Pi)
• Find a solution to support vaapi_vld and vaapi pixel formats to support both ffmpeg 4 and ffmpeg 5.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If this was a feature request that others have shown no interest in then it's likely to not get implemented due to lack of interest. If others also want to see this feature then now is the time to say something! Thank you for your contributions.

[gabek]

Due to the limited number of people using dedicated hardware this hasn't been more of an issue, but it's still on the todo list.

[gabek]

An update:

As far as I can tell ffmpeg 5 has been working for everyone except those trying to use vaapi, and I've only been made aware of two people trying to use ffmpeg5+vaapi. Due to the lack of impact, this has not been a priority.

However, if anybody else wanted to pick this up to test, verify and support the new pixel format it'd be great. Otherwise it'll continue to be pushed off until the larger projects that are in the works are released.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If this was a feature request that others have shown no interest in then it's likely to not get implemented due to lack of interest. If others also want to see this feature then now is the time to say something! Thank you for your contributions.