UI changes and modernizr.js for the contacts app.

[raghunayyar]

Modernizr.js and Placeholder Polyfills library included for the old browser support.
The input elements now float correctly.
Bug http://bugs.owncloud.org/thebuggenie/files/show/73 solved.

[DeepDiver1975]

THX

Please add the un-minified version of Modernizr.js as well.
Minified js is considered as binary and to fulfill copyrights we need to deliver the source as well.

THX a lot,

Tom

[raghunayyar]

Done. :)

On Tue, Aug 28, 2012 at 4:49 PM, Thomas Müller notifications@github.comwrote:

THX

Please add the un-minified version of Modernizr.js as well.
Minified js is considered as binary and to fulfill copyrights we need to
deliver the source as well.

THX a lot,

Tom

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/1#issuecomment-8088268.

Sincerely,
Raghu

[icewind1991]

I've been thinking about this earlier, isn't it enough to just link people to the un-minified version.

Most open source licenses don't force you to bundle the source with the binaries, you just have to provide the source when asked for, a smartphone doesn't come with the full linux source, only a mention in the manual where you can find the source.

[DeepDiver1975]

Well - there is for sure some room for interpretation.

I - being the Debain Package Maintainer - have to follow the Debian guidelines, which interpret the licenses very strict.
The rule is actually pretty easy: you need to be capable to build the whole software from the source including the capability to change any piece.
As changing a minified javascript is almost impossible - or at least big pain: we need to include the unminified version.

[tanghus]

I intentionally dropped having it fixed a while ago because it would overlap elements.

[tanghus]

Thanks Raghu. Sorry again for not being able to merge it earlier. I haven't had time to work on ownCloud for almost a week. Can I get you to update it with latest master to add the changes I've made during that time?

[raghunayyar]

Sure! That will be great!
On 31 Aug 2012 00:02, "Thomas Tanghus" notifications@github.com wrote:

Thanks Raghu. Sorry again for not being able to merge it earlier. I
haven't had time to work on ownCloud for almost a week. Can I get you to
update it with latest master to add the changes I've made during that time?

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/1#issuecomment-8169580.

[tanghus]

@raghunayyar Should we also drop the minified version, or is it customized to only check for placeholder?

[raghunayyar]

It was not just for the placeholders. It was in general because we thought
applying modernizr.js to core so that it may be accessed if required by all
the apps.
On 31 Aug 2012 02:30, "Thomas Tanghus" notifications@github.com wrote:

@raghunayyar https://github.com/raghunayyar Should we also drop the
minified version, or is it customized to only check for placeholder?

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/1#issuecomment-8174296.

[tanghus]

Cool, then just remove the minified version.