New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use optimized autoloader #211

Merged
merged 2 commits into from Oct 25, 2015

Conversation

Projects
None yet
4 participants
@LukasReschke
Member

LukasReschke commented Oct 25, 2015

Saves a few ms per request (actually pretty much considering relative numbers, we measured 5-15ms - this is huge for WebDAV requests!). This has not been done in the past as it caused problems for unofficial packages. IF distributions decide to do Frankenstein releases where they remove some libraries or move it to a system-wide one then they would have to modify this file as well.

I consider this absolutely sensible given that this overall is an improvement. If somebody wants to do such unsupported releases they should be able to also adjust this as well

@rullzer As discussed.
@DeepDiver1975 FYI - please make sure that all PRs are always using --optimize-autoloader. (resolved by #211 (comment))

@LukasReschke

This comment has been minimized.

Show comment
Hide comment
@LukasReschke
Member

LukasReschke commented Oct 25, 2015

@rullzer

This comment has been minimized.

Show comment
Hide comment
@rullzer

rullzer Oct 25, 2015

Contributor

👍 yes please!!

Contributor

rullzer commented Oct 25, 2015

👍 yes please!!

@LukasReschke

This comment has been minimized.

Show comment
Hide comment
@LukasReschke

LukasReschke Oct 25, 2015

Member

Aha! It is possible to set such values in composer.json. Let's try this.

Member

LukasReschke commented Oct 25, 2015

Aha! It is possible to set such values in composer.json. Let's try this.

@Xenopathic

This comment has been minimized.

Show comment
Hide comment
@Xenopathic

Xenopathic Oct 25, 2015

Member

👍

Now we just need core using Composer directly too, then everything will be super fast!

Member

Xenopathic commented Oct 25, 2015

👍

Now we just need core using Composer directly too, then everything will be super fast!

LukasReschke added a commit that referenced this pull request Oct 25, 2015

@LukasReschke LukasReschke merged commit 3fc181b into master Oct 25, 2015

@LukasReschke LukasReschke deleted the optimized-autoloader branch Oct 25, 2015

@karlitschek

This comment has been minimized.

Show comment
Hide comment
@karlitschek

karlitschek Oct 25, 2015

Member

Agreed. 👍

Member

karlitschek commented Oct 25, 2015

Agreed. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment