Remove left margin from files tabview #475

Closed
ChristophWurst opened this Issue Mar 10, 2016 · 6 comments

Projects

None yet

4 participants

@ChristophWurst
Contributor

Left margin causes inconsistency of different tabs in the files sidebar:

The activity tab with margin:
bildschirmfoto von 2016-03-10 08-58-53
Other tabs don't have it:
bildschirmfoto von 2016-03-10 08-59-04

@nickvergessen @jancborchardt is that intended?

@nickvergessen
Contributor

Well the problem is, if you modify/add/delete/share the file, we have the icon.
basically comment activities miss an icon, that is why they look "too far intended".

@jancborchardt can you craft an icon please?

@jancborchardt
Member

There already is an icon: icon-comment. I wouldn’t add it while the tab is separate though since it will just result in repeated icons.

So we should wait for the Activity tab being combined in core.

@nickvergessen
Contributor

The change and share icon can repeat too...

@jancborchardt
Member

I know. But the comment icon will definitely be the only icon in the comments tab. So it does not make any sense to use it, cause it doesn’t help to distinguish anything – it’s just visual noise.

@nickvergessen
Contributor

We are talking abou tthe activity app and stream, which would be good to have an icon for.
I will test icon-comment

@jancborchardt
Member

Right, true. Misunderstanding since the original issie was about the margin. Yes, definitely goos to add the icon-comment when it's a mixed actions list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment