Avatar image in activity tab broken for "remote user" #529

Closed
fmkaiser opened this Issue Aug 1, 2016 · 0 comments

Projects

None yet

2 participants

@fmkaiser
Contributor
fmkaiser commented Aug 1, 2016

Steps to reproduce

  1. Enable Activity App
  2. Create "editable" public share
  3. Upload something into it using the public link
  4. As the owner, check the activities tab for the uploaded object

Expected behaviour

The entry created by "remote user" should have either some generic or no avatar.

Actual behaviour

owncloud_activity_remoteuser
Entry for "remote user" links to non-existing avatar image, showing ugly placeholder instead.

Server configuration

  • ownCloud 9.1
  • Activities 2.3.2

Analysis

js/activitytabview.js:170 element.avatar(element.data('user'), 28) generates a broken link if user is empty.
The main activity view js/script.js:254 uses the (first character of) the display name as "icon" if a username is not available. In the case of "remote user" (hard coded in lib/Formatter/UserFormatter.php:54), that's the quotation mark. Whether that's the best option is open to discussion, however it's definitely better than the broken image. I'll submit a pull request to do the same for the tab view shortly.

@DeepDiver1975 DeepDiver1975 added this to the 9.2 milestone Aug 9, 2016
@DeepDiver1975 DeepDiver1975 added the bug label Aug 9, 2016
@DeepDiver1975 DeepDiver1975 closed this in #530 Aug 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment