[9.0] Fix displaying of the date in the sidebar #517

Merged
merged 1 commit into from May 4, 2016

Projects

None yet

3 participants

@nickvergessen
Contributor
nickvergessen commented Apr 26, 2016 edited

Backport of #516

  1. Enable activity app
  2. Create a new file
  3. Open sidebar of the file
  4. On the create activity try to find the date
@nickvergessen nickvergessen Fix displaying of the date in the sidebar
c7bd373
@mention-bot

By analyzing the blame information on this pull request, we identified @PVince81 to be a potential reviewer

@nickvergessen nickvergessen changed the title from Fix displaying of the date in the sidebar to [9.0] Fix displaying of the date in the sidebar Apr 26, 2016
@PVince81
Contributor

If not critical I'd prefer to get this into 9.0.3. Hopefully by then I'll get to review the linked PRs as well 😄

@nickvergessen
Contributor

Wow, really? Uploading a file and opening the sidebar is too much being asked for?
3 lines changed (ignoring tests)...

The linked PR is much bigger atm, because it code depends on another PR...

@PVince81
Contributor

From what I see it is tagged as medium. We only merge PRs for 9.0.2 for critical/high issues especially this late.

Anyway, going to review your other PRs so we can move this forward.

@PVince81
Contributor

Tested, works 👍

@nickvergessen nickvergessen merged commit 8c58dcb into stable9 May 4, 2016

2 checks passed

Scrutinizer No new issues
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@nickvergessen nickvergessen deleted the backport-516-missing-date-in-sidebar branch May 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment