Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed ConfirmationDialog behaviour on outside the dialog touch #2491

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
3 participants
@sd1998
Copy link
Member

commented Mar 16, 2019

Fix to issue #2478.

@sd1998 sd1998 changed the title Fixed ConfirmationDialog behaviour on outside touch Fixed ConfirmationDialog behaviour on outside the dialog touch Mar 16, 2019

@sd1998

This comment has been minimized.

Copy link
Member Author

commented Mar 16, 2019

@jesmrec I have fixed #2478.

mueller-ma added a commit to mueller-ma/android that referenced this pull request Mar 16, 2019

@mueller-ma
Copy link
Contributor

left a comment

Instead of disabling the cancel behavior completely, I opened #2492 to fix this issue.

@jesmrec

This comment has been minimized.

Copy link
Contributor

commented Apr 3, 2019

we finally went for the fix in #2492 to fix the issue #2478. Anyway, thanks for you effort!

@jesmrec jesmrec closed this Apr 3, 2019

mueller-ma added a commit to mueller-ma/android that referenced this pull request Apr 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.