Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Convert AsyncTask to IntentService #969
Hey owncloud-android developers, I'm doing research on Android async programming, particularly on
We discussed with some Android experts and they agree with this issue, and claim that AsyncTask can be considered only for short tasks (less than 1 second). However, using IntentService (or AsyncTaskLoader) can avoid such problems since their lifecycles are independent from
For example, in
I refactored three AsyncTasks in
Thanks for your contribution.
Is it your first contribution in the OwnCloud Project? I've been searching your nickname in the developers list and I have not found it. If you haven't signed the Contributor Agreement, please send it ( https://owncloud.org/contribute/agreement/) to @karlitschek. We can't merged your PR without this agreement.
On the other hand, could you update your branch with the last version of the code? It is better to do the code review easily.
A question, why did you select IntentService instead of AsyncTaskLoader as in your PR #892?
Need to think a bit about this. Not sure that replacing
At first sight, I see a possible problem with returning results through
Besides, we'd like reduce the number of
Thanks a lot for your contribution!
Alternatively you can add a comment here where you state that this contribution is MIT licensed.
Some more details about out pull request workflow can be found here: http://owncloud.org/code-reviews-on-github/