UI changes and modernizr.js for the contacts app. #1

Closed
wants to merge 9 commits into
from

Projects

None yet

4 participants

@raghunayyar
Member

Modernizr.js and Placeholder Polyfills library included for the old browser support.
The input elements now float correctly.
Bug http://bugs.owncloud.org/thebuggenie/files/show/73 solved.

raghunayyar and others added some commits Aug 27, 2012
@raghunayyar raghunayyar Update contacts/css/contacts.css
Made the required UI changes, the messaging input also floats properly now. 
Bug Bug http://bugs.owncloud.org/thebuggenie/files/show/73 solved.
465eba7
@raghunayyar raghunayyar Update contacts/templates/part.contact.php eb25041
raghu Updated contacts/index.php
modernizr.js and HTML5 polyfills for placeholders added.
c904ea3
@DeepDiver1975
Member

THX

Please add the un-minified version of Modernizr.js as well.
Minified js is considered as binary and to fulfill copyrights we need to deliver the source as well.

THX a lot,

Tom

@raghunayyar
Member

Done. :)

On Tue, Aug 28, 2012 at 4:49 PM, Thomas Müller notifications@github.comwrote:

THX

Please add the un-minified version of Modernizr.js as well.
Minified js is considered as binary and to fulfill copyrights we need to
deliver the source as well.

THX a lot,

Tom


Reply to this email directly or view it on GitHubhttps://github.com/owncloud/apps/pull/1#issuecomment-8088268.

Sincerely,
Raghu

@tanghus tanghus was assigned Aug 28, 2012
@icewind1991
Member

I've been thinking about this earlier, isn't it enough to just link people to the un-minified version.

Most open source licenses don't force you to bundle the source with the binaries, you just have to provide the source when asked for, a smartphone doesn't come with the full linux source, only a mention in the manual where you can find the source.

@DeepDiver1975
Member

Well - there is for sure some room for interpretation.

I - being the Debain Package Maintainer - have to follow the Debian guidelines, which interpret the licenses very strict.
The rule is actually pretty easy: you need to be capable to build the whole software from the source including the capability to change any piece.
As changing a minified javascript is almost impossible - or at least big pain: we need to include the unminified version.

@raghunayyar raghunayyar reopened this Aug 30, 2012
@tanghus tanghus commented on the diff Aug 30, 2012
contacts/css/contacts.css
@@ -16,7 +16,7 @@
#uploadprogressbar { display: none; padding: 0; bottom: 3em; height:2em; width: 20em; margin:0; background:#eee; border:1px solid #ccc; position:fixed; }
#contacts_newcontact, #bottomcontrols .settings { float: left; margin: 0.2em 0 0 1em; border: 0 none; border-radius: 0; -moz-box-shadow: none; box-shadow: none; outline: 0 none; }
#bottomcontrols .settings { float: right; margin: 0.2em 1em 0 0; }
-#actionbar { clear: both; height: 30px;}
+#actionbar { clear: both; height: 30px; position: fixed; top:200px; }
@tanghus
tanghus Aug 30, 2012 Member

I intentionally dropped having it fixed a while ago because it would overlap elements.

@tanghus tanghus commented on the diff Aug 30, 2012
contacts/css/contacts.css
@@ -71,9 +71,9 @@ label:hover, dt:hover { color: #333; }
#fn { float: left !important; width: 18em !important; }
#name { /*position: absolute; top: 0px; left: 0px;*/ min-width: 25em; height: 2em; clear: right; display: block; }
#identityprops { /*position: absolute; top: 2.5em; left: 0px;*/ }
-#contact_photo { float: left; margin: 1em; }
-#contact_identity { min-width: 30em; padding: 0.5em;}
-.contactsection { position: relative; float: left; width: 35em; padding: 0.5em; height: auto; }
+#contact_photo { position: fixed; padding: 0.5em ; }
+#contact_identity { min-width: 30em; padding: 0.5em; }
+.contactsection { position: relative; clear: left; width: 50em; margin-left:200px; height: auto; }
@tanghus
tanghus Aug 30, 2012 Member

Changing float: left; to clear: left; will prevent the sections from floating which is a waste of space on wide-screen monitors. What we want is a floating solution that supports both wide monitors and e.g. phones.

@tanghus tanghus commented on the diff Aug 30, 2012
contacts/css/contacts.css
@@ -32,7 +32,7 @@
#card input[type="text"].contacts_property,input[type="email"].contacts_property,input[type="url"].contacts_property { width: 14em; float: left; font-weight: bold; }
.categories { float: left; width: 16em; }
-#card input[type="checkbox"].contacts_property, #card input[type="text"], #card input[type="email"], #card input[type="url"], #card input[type="tel"], #card input[type="date"], #card select, #card textarea { background-color: #fefefe; border: 0 !important; -moz-appearance:none !important; -webkit-box-sizing:none !important; -moz-box-sizing:none !important; box-sizing:none !important; -moz-box-shadow: none; -webkit-box-shadow: none; box-shadow: none; -moz-border-radius: 0px; -webkit-border-radius: 0px; border-radius: 0px; float: left; }
+#card input[type="checkbox"].contacts_property, #card input[type="text"], #card input[type="email"], #card input[type="url"], #card input[type="tel"], #card input[type="date"], #card select, #card textarea { background-color: #fefefe; border: 0 !important; -moz-appearance:none !important; -webkit-box-sizing:none !important; -moz-box-sizing:none !important; box-sizing:none !important; -moz-box-shadow: none; -webkit-box-shadow: none; box-shadow: none; -moz-border-radius: 0px; -webkit-border-radius: 0px; border-radius: 0px; float: left; font-size: 14px; }
@tanghus
tanghus Aug 30, 2012 Member

We shouldn't use fixed px font-sizes. I have added a base font-size of 10 px. Not ideal, but at least there is less difference between the browsers now.

@tanghus tanghus commented on the diff Aug 30, 2012
contacts/index.php
@@ -54,6 +54,9 @@
OCP\Util::addscript('files', 'jquery.fileupload');
OCP\Util::addscript('core', 'jquery.inview');
OCP\Util::addscript('contacts', 'jquery.Jcrop');
+OCP\Util::addscript('contacts', 'modernizr');
@tanghus
tanghus Aug 30, 2012 Member

I don't think you have to add the unminified version here? It is just for license reasons that it has to be distributed in the packages.

@DeepDiver1975
DeepDiver1975 Aug 30, 2012 Member

As we have the minifiers in place we can skip all minified js - don't we?

@tanghus
tanghus Aug 30, 2012 Member

You've got a point there ;)

@tanghus
Member
tanghus commented Aug 30, 2012

Thanks Raghu. Sorry again for not being able to merge it earlier. I haven't had time to work on ownCloud for almost a week. Can I get you to update it with latest master to add the changes I've made during that time?

@raghunayyar
Member

Sure! That will be great!
On 31 Aug 2012 00:02, "Thomas Tanghus" notifications@github.com wrote:

Thanks Raghu. Sorry again for not being able to merge it earlier. I
haven't had time to work on ownCloud for almost a week. Can I get you to
update it with latest master to add the changes I've made during that time?


Reply to this email directly or view it on GitHubhttps://github.com/owncloud/apps/pull/1#issuecomment-8169580.

@tanghus
Member
tanghus commented Aug 30, 2012

@raghunayyar Should we also drop the minified version, or is it customized to only check for placeholder?

@raghunayyar
Member

It was not just for the placeholders. It was in general because we thought
applying modernizr.js to core so that it may be accessed if required by all
the apps.
On 31 Aug 2012 02:30, "Thomas Tanghus" notifications@github.com wrote:

@raghunayyar https://github.com/raghunayyar Should we also drop the
minified version, or is it customized to only check for placeholder?


Reply to this email directly or view it on GitHubhttps://github.com/owncloud/apps/pull/1#issuecomment-8174296.

@tanghus
Member
tanghus commented Aug 30, 2012

Cool, then just remove the minified version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment