UI changes and modernizr.js for the contacts app. #1

raghunayyar · 2012-08-27T21:06:29Z

Modernizr.js and Placeholder Polyfills library included for the old browser support.
The input elements now float correctly.
Bug http://bugs.owncloud.org/thebuggenie/files/show/73 solved.

Made the required UI changes, the messaging input also floats properly now. Bug Bug http://bugs.owncloud.org/thebuggenie/files/show/73 solved.

modernizr.js and HTML5 polyfills for placeholders added.

DeepDiver1975 · 2012-08-28T11:19:01Z

THX

Please add the un-minified version of Modernizr.js as well.
Minified js is considered as binary and to fulfill copyrights we need to deliver the source as well.

THX a lot,

Tom

raghunayyar · 2012-08-28T11:45:51Z

Done. :)

On Tue, Aug 28, 2012 at 4:49 PM, Thomas Müller notifications@github.comwrote:

THX

Please add the un-minified version of Modernizr.js as well.
Minified js is considered as binary and to fulfill copyrights we need to
deliver the source as well.

THX a lot,

Tom

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/1#issuecomment-8088268.

Sincerely,
Raghu

icewind1991 · 2012-08-28T12:25:50Z

I've been thinking about this earlier, isn't it enough to just link people to the un-minified version.

Most open source licenses don't force you to bundle the source with the binaries, you just have to provide the source when asked for, a smartphone doesn't come with the full linux source, only a mention in the manual where you can find the source.

DeepDiver1975 · 2012-08-28T12:45:18Z

Well - there is for sure some room for interpretation.

I - being the Debain Package Maintainer - have to follow the Debian guidelines, which interpret the licenses very strict.
The rule is actually pretty easy: you need to be capable to build the whole software from the source including the capability to change any piece.
As changing a minified javascript is almost impossible - or at least big pain: we need to include the unminified version.

syntax error resolved

This reverts commit 0504d31.

This reverts commit c90f3ff.

This reverts commit 185b491.

tanghus · 2012-08-30T18:14:06Z

contacts/css/contacts.css

@@ -16,7 +16,7 @@
 #uploadprogressbar { display: none; padding: 0; bottom: 3em; height:2em; width: 20em; margin:0; background:#eee; border:1px solid #ccc; position:fixed; }
 #contacts_newcontact, #bottomcontrols .settings { float: left; margin: 0.2em 0 0 1em; border: 0 none; border-radius: 0; -moz-box-shadow: none; box-shadow: none; outline: 0 none; }
 #bottomcontrols .settings { float: right; margin: 0.2em 1em 0 0; }
-#actionbar { clear: both; height: 30px;}
+#actionbar { clear: both; height: 30px; position: fixed; top:200px; }


I intentionally dropped having it fixed a while ago because it would overlap elements.

tanghus · 2012-08-30T18:19:34Z

contacts/css/contacts.css

-.contactsection { position: relative; float: left; width: 35em; padding: 0.5em; height: auto; }
+#contact_photo { position: fixed; padding: 0.5em ; }
+#contact_identity { min-width: 30em; padding: 0.5em; }
+.contactsection { position: relative; clear: left; width: 50em; margin-left:200px; height: auto; }


Changing float: left; to clear: left; will prevent the sections from floating which is a waste of space on wide-screen monitors. What we want is a floating solution that supports both wide monitors and e.g. phones.

tanghus · 2012-08-30T18:26:11Z

contacts/css/contacts.css

@@ -32,7 +32,7 @@

 #card input[type="text"].contacts_property,input[type="email"].contacts_property,input[type="url"].contacts_property { width: 14em; float: left; font-weight: bold; }
 .categories { float: left; width: 16em; }
-#card input[type="checkbox"].contacts_property, #card input[type="text"], #card input[type="email"], #card input[type="url"], #card input[type="tel"], #card input[type="date"], #card select, #card textarea { background-color: #fefefe; border: 0 !important; -moz-appearance:none  !important; -webkit-box-sizing:none !important; -moz-box-sizing:none !important; box-sizing:none !important; -moz-box-shadow: none; -webkit-box-shadow: none; box-shadow: none; -moz-border-radius: 0px; -webkit-border-radius: 0px; border-radius: 0px; float: left; }
+#card input[type="checkbox"].contacts_property, #card input[type="text"], #card input[type="email"], #card input[type="url"], #card input[type="tel"], #card input[type="date"], #card select, #card textarea { background-color: #fefefe; border: 0 !important; -moz-appearance:none  !important; -webkit-box-sizing:none !important; -moz-box-sizing:none !important; box-sizing:none !important; -moz-box-shadow: none; -webkit-box-shadow: none; box-shadow: none; -moz-border-radius: 0px; -webkit-border-radius: 0px; border-radius: 0px; float: left; font-size: 14px; }


We shouldn't use fixed px font-sizes. I have added a base font-size of 10 px. Not ideal, but at least there is less difference between the browsers now.

tanghus · 2012-08-30T18:28:42Z

contacts/index.php

@@ -54,6 +54,9 @@
 OCP\Util::addscript('files', 'jquery.fileupload');
 OCP\Util::addscript('core', 'jquery.inview');
 OCP\Util::addscript('contacts', 'jquery.Jcrop');
+OCP\Util::addscript('contacts', 'modernizr');


I don't think you have to add the unminified version here? It is just for license reasons that it has to be distributed in the packages.

As we have the minifiers in place we can skip all minified js - don't we?

You've got a point there ;)

tanghus · 2012-08-30T18:32:43Z

Thanks Raghu. Sorry again for not being able to merge it earlier. I haven't had time to work on ownCloud for almost a week. Can I get you to update it with latest master to add the changes I've made during that time?

raghunayyar · 2012-08-30T18:34:56Z

Sure! That will be great!
On 31 Aug 2012 00:02, "Thomas Tanghus" notifications@github.com wrote:

Thanks Raghu. Sorry again for not being able to merge it earlier. I
haven't had time to work on ownCloud for almost a week. Can I get you to
update it with latest master to add the changes I've made during that time?

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/1#issuecomment-8169580.

tanghus · 2012-08-30T21:00:00Z

@raghunayyar Should we also drop the minified version, or is it customized to only check for placeholder?

raghunayyar · 2012-08-30T21:02:40Z

It was not just for the placeholders. It was in general because we thought
applying modernizr.js to core so that it may be accessed if required by all
the apps.
On 31 Aug 2012 02:30, "Thomas Tanghus" notifications@github.com wrote:

@raghunayyar https://github.com/raghunayyar Should we also drop the
minified version, or is it customized to only check for placeholder?

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/1#issuecomment-8174296.

tanghus · 2012-08-30T21:23:02Z

Cool, then just remove the minified version.

raghunayyar and others added 3 commits Aug 27, 2012

Update contacts/css/contacts.css

465eba7

Made the required UI changes, the messaging input also floats properly now. Bug Bug http://bugs.owncloud.org/thebuggenie/files/show/73 solved.

Update contacts/templates/part.contact.php

eb25041

Updated contacts/index.php

c904ea3

modernizr.js and HTML5 polyfills for placeholders added.

Added Un minified Version of modernizer.js

291f159

ghost assigned tanghus Aug 28, 2012

raghunayyar closed this Aug 30, 2012

raghunayyar reopened this Aug 30, 2012

raghunayyar and others added 5 commits Aug 30, 2012

Update impress/css/style.css

0504d31

syntax error resolved

Revert "Update impress/css/style.css"

c90f3ff

This reverts commit 0504d31.

Revert "Revert "Update impress/css/style.css""

185b491

This reverts commit c90f3ff.

Revert "Revert "Revert "Update impress/css/style.css"""

b74827d

This reverts commit 185b491.

.DS_Store removed.

821bb3a

tanghus reviewed Aug 30, 2012
View changes

raghunayyar closed this Aug 31, 2012

msrex mentioned this pull request Dec 8, 2012

oc-1485 - Ampache remote interface ignores password change #313

Closed

traysh mentioned this pull request Jan 13, 2013

Pictures: wrong path if path has special chars #155

Closed

This was referenced Mar 13, 2013

5.0.0 RC3 [Contacts] Exception is thrown without reason. #743

Closed

OC 5.0.0 RC3 - [FILES] Problem with mimetype for MSI #745

Closed

This was referenced Mar 19, 2013

OC5.0.0 RC3: No indexing of mp3 in media folder #734

Closed

Playing a song in the web client Media app results in a "Token expired" response from the API #816

Closed

xfirf mentioned this pull request Apr 16, 2013

Name Sorting in Contacts in inconsistent #1016

Closed

outilsconviviaux mentioned this pull request Nov 24, 2013

Shared Calendar can not be downloaded #884

Closed

enoch85 mentioned this pull request Dec 11, 2013

search_lucene Cross-reference streams are not supported yet #1547

Closed

rjbur007 mentioned this pull request Feb 10, 2014

Support for Reminders #34

Closed

lyallp mentioned this pull request Mar 13, 2015

External Files - DropBox - Updated file, modified date not updated #2031

Closed

dichen001 mentioned this pull request Jun 28, 2016

Summary of the 20 issues in Herbsleb's 2014 FSE paper. dichen001/Paper-Reading#6

Open

owncloud / apps Archived

UI changes and modernizr.js for the contacts app. #1

UI changes and modernizr.js for the contacts app. #1

raghunayyar commented Aug 27, 2012

DeepDiver1975 commented Aug 28, 2012

raghunayyar commented Aug 28, 2012

icewind1991 commented Aug 28, 2012

DeepDiver1975 commented Aug 28, 2012

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

tanghus commented Aug 30, 2012

raghunayyar commented Aug 30, 2012

tanghus commented Aug 30, 2012

raghunayyar commented Aug 30, 2012

tanghus commented Aug 30, 2012

owncloud / apps Archived

UI changes and modernizr.js for the contacts app. #1

UI changes and modernizr.js for the contacts app. #1

Conversation

raghunayyar commented Aug 27, 2012

DeepDiver1975 commented Aug 28, 2012

raghunayyar commented Aug 28, 2012

icewind1991 commented Aug 28, 2012

DeepDiver1975 commented Aug 28, 2012

This comment has been minimized.

tanghus Aug 30, 2012 Contributor

This comment has been minimized.

tanghus Aug 30, 2012 Contributor

This comment has been minimized.

tanghus Aug 30, 2012 Contributor

This comment has been minimized.

tanghus Aug 30, 2012 Contributor

This comment has been minimized.

DeepDiver1975 Aug 30, 2012 Member

This comment has been minimized.

tanghus Aug 30, 2012 Contributor

tanghus commented Aug 30, 2012

raghunayyar commented Aug 30, 2012

tanghus commented Aug 30, 2012

raghunayyar commented Aug 30, 2012

tanghus commented Aug 30, 2012

tanghus Aug 30, 2012
Contributor

tanghus Aug 30, 2012
Contributor

tanghus Aug 30, 2012
Contributor

tanghus Aug 30, 2012
Contributor

DeepDiver1975 Aug 30, 2012
Member

tanghus Aug 30, 2012
Contributor