New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Activity app design #1769

Merged
merged 29 commits into from May 14, 2014

Conversation

Projects
None yet
5 participants
@jancborchardt
Member

jancborchardt commented Apr 23, 2014

🚧

@nickvergessen let’s use this for working on the Activity app design. Essentially we should move to an easier to read list view. Here’s a basic mockup of how it should look:
owncloud activity app mockup

  • have text be like a sentence: »shared test with Tom« (including share icon, filename in bold, and avatar left next to friend username)
  • use icons for actions on the left
    • green + added
    • red x deleted
    • blue circular arrows changed
    • black/grey shared icon
    • black/grey renamed icon
    • black/grey moved icon
  • don’t show own username or avatars, only say »You« (missing in the mockup)
  • multiple files not in a list, but in text: »Photo, Document, 9 more …«
    • hover over »9 more…« shows a tipsy tooltip with the other files
  • show only filename, full path only on hover in a tipsy tooltip
  • group by actions and dates (this is done already I believe?)

That’s basically it. What do you think?

Open bugs:

  • .txt previews are generated with a white background, which is now displayed on white background instead of gray background as before see
  • it's too hard to guess which date belongs to which activity when your screen is a bit bigger see
  • when you share something with someone (or receive a share), the avatar should be shown left next to the name of that person. (Do not show the avatar of the current user!) see
  • what is that »$2a$08$ebx4UI…«? see
  • big previews only for images for now, the others don’t work too well
  • layout is borked on long lines (I’ll fix that) see

Fixes #1676

@jancborchardt jancborchardt added this to the ownCloud 7 milestone Apr 23, 2014

@jancborchardt

This comment has been minimized.

Show comment
Hide comment
@jancborchardt

jancborchardt Apr 23, 2014

Member

@nickvergessen can you take over?

The activitysubject needs to be modified according to the tasks above. Probably split into action (change, add, rename, share, delete …), person who did the action (mostly yourself), recipient (for shares), and filename.
I also added the icons, which can simply be used by assigning the class like »icon-change-color« or »icon-shared«.

Member

jancborchardt commented Apr 23, 2014

@nickvergessen can you take over?

The activitysubject needs to be modified according to the tasks above. Probably split into action (change, add, rename, share, delete …), person who did the action (mostly yourself), recipient (for shares), and filename.
I also added the icons, which can simply be used by assigning the class like »icon-change-color« or »icon-shared«.

@MorrisJobke

This comment has been minimized.

Show comment
Hide comment
@MorrisJobke
Member

MorrisJobke commented May 5, 2014

@jancborchardt

This comment has been minimized.

Show comment
Hide comment
@jancborchardt

jancborchardt May 5, 2014

Member

@nickvergessen you said you already had some of the improvements locally? Can you push them here?

Member

jancborchardt commented May 5, 2014

@nickvergessen you said you already had some of the improvements locally? Can you push them here?

@nickvergessen

This comment has been minimized.

Show comment
Hide comment
@nickvergessen

nickvergessen May 5, 2014

Contributor

@jancborchardt the local work is based on #1685 will do, as soon as it got merged

Contributor

nickvergessen commented May 5, 2014

@jancborchardt the local work is based on #1685 will do, as soon as it got merged

@jancborchardt

This comment has been minimized.

Show comment
Hide comment
@jancborchardt

jancborchardt May 13, 2014

Member

@nickvergessen #1685 is merged now, can we move on with the design?

Member

jancborchardt commented May 13, 2014

@nickvergessen #1685 is merged now, can we move on with the design?

@nickvergessen

This comment has been minimized.

Show comment
Hide comment
@nickvergessen

nickvergessen May 14, 2014

Contributor

Rebased and updated:
Grouped activities show the icon at the bottom of the list:

grouped-activities-icon-bottom

.txt previews are generated with a white background, which is now displayed on white background instead of gray background as before:

txt-preview-no-background

it's too hard to guess which date belongs to which activity when your screen is a bit bigger:

date-action-link

Contributor

nickvergessen commented May 14, 2014

Rebased and updated:
Grouped activities show the icon at the bottom of the list:

grouped-activities-icon-bottom

.txt previews are generated with a white background, which is now displayed on white background instead of gray background as before:

txt-preview-no-background

it's too hard to guess which date belongs to which activity when your screen is a bit bigger:

date-action-link

@nickvergessen

This comment has been minimized.

Show comment
Hide comment
@nickvergessen

nickvergessen May 14, 2014

Contributor
  • Sharing a folder has no icon:

missing-icon-for-shared

Contributor

nickvergessen commented May 14, 2014

  • Sharing a folder has no icon:

missing-icon-for-shared

@jancborchardt

This comment has been minimized.

Show comment
Hide comment
@jancborchardt

jancborchardt May 14, 2014

Member

Grouped activities show the icon at the bottom of the list:

Fixed that one.

.txt previews are generated with a white background, which is now displayed on white background instead of gray background as before:

I’d say that’s only a test-case issue for now as it only happens when you create »test« files with almost nothing in it. Normally I would add a slight border around it, but that would make filetype icons look silly. Let’s leave it.

it's too hard to guess which date belongs to which activity when your screen is a bit bigger

Yeah, true. Then again, the date isn’t that important so it shouldn’t be too prominent. Will look into that later.

Member

jancborchardt commented May 14, 2014

Grouped activities show the icon at the bottom of the list:

Fixed that one.

.txt previews are generated with a white background, which is now displayed on white background instead of gray background as before:

I’d say that’s only a test-case issue for now as it only happens when you create »test« files with almost nothing in it. Normally I would add a slight border around it, but that would make filetype icons look silly. Let’s leave it.

it's too hard to guess which date belongs to which activity when your screen is a bit bigger

Yeah, true. Then again, the date isn’t that important so it shouldn’t be too prominent. Will look into that later.

@jancborchardt

This comment has been minimized.

Show comment
Hide comment
@jancborchardt

jancborchardt May 14, 2014

Member
  • the file names / folder names should be bold for easier readability
  • grouped file actions should be displayed in a row, not in a list (and not repeat the action) so instead of the »You created x, you created y, you created z …«, it should say: »You created x, y, z and 3 more …« in one line
  • when you share something with someone (or receive a share), the avatar should be shown left next to the name of that person. (Do not show the avatar of the current user!)
  • if I scroll down further, there’s no text on the activities
Member

jancborchardt commented May 14, 2014

  • the file names / folder names should be bold for easier readability
  • grouped file actions should be displayed in a row, not in a list (and not repeat the action) so instead of the »You created x, you created y, you created z …«, it should say: »You created x, y, z and 3 more …« in one line
  • when you share something with someone (or receive a share), the avatar should be shown left next to the name of that person. (Do not show the avatar of the current user!)
  • if I scroll down further, there’s no text on the activities

nickvergessen added some commits May 14, 2014

Merge branch 'activity-design' of https://github.com/owncloud/apps in…
…to activity-design

# By Jan-Christoph Borchardt
# Via Jan-Christoph Borchardt
* 'activity-design' of https://github.com/owncloud/apps:
  align icons to top in activity groups
  change colored change icon to black/grey for less distraction
@nickvergessen

This comment has been minimized.

Show comment
Hide comment
@nickvergessen

nickvergessen May 14, 2014

Contributor

grouped file actions should be displayed in a row, not in a list (and not repeat the action) so instead of the »You created x, you created y, you created z …«, it should say: »You created x, y, z and 3 more …« in one line

Moved to new issue owncloud/activity#2

Contributor

nickvergessen commented May 14, 2014

grouped file actions should be displayed in a row, not in a list (and not repeat the action) so instead of the »You created x, you created y, you created z …«, it should say: »You created x, y, z and 3 more …« in one line

Moved to new issue owncloud/activity#2

@nickvergessen

This comment has been minimized.

Show comment
Hide comment
@nickvergessen

nickvergessen May 14, 2014

Contributor

if I scroll down further, there’s no text on the activities

Works for me

Contributor

nickvergessen commented May 14, 2014

if I scroll down further, there’s no text on the activities

Works for me

@jancborchardt

This comment has been minimized.

Show comment
Hide comment
@jancborchardt

jancborchardt May 14, 2014

Member

Some more issues:
activity-issues

  • oftentimes the first letter of the file/folder name is not shown
  • what is that »$2a$08$ebx4UI…«?
  • older events which were lazily loaded miss the »You added file« text entirely
  • layout is borked on long lines (I’ll fix that)
Member

jancborchardt commented May 14, 2014

Some more issues:
activity-issues

  • oftentimes the first letter of the file/folder name is not shown
  • what is that »$2a$08$ebx4UI…«?
  • older events which were lazily loaded miss the »You added file« text entirely
  • layout is borked on long lines (I’ll fix that)
@nickvergessen

This comment has been minimized.

Show comment
Hide comment
@nickvergessen

nickvergessen May 14, 2014

Contributor

oftentimes the first letter of the file/folder name is not shown

This was due to a bug-fix in owncloud activities that have been created between the bug-fix and the fix in activity apps are broken forever, but this is master-only.

what is that »$2a$08$ebx4UI…«?

Looks like a key, did you share it via link with password or something?

older events which were lazily loaded miss the »You added file« text entirely

is related to the same issue as 1.

Contributor

nickvergessen commented May 14, 2014

oftentimes the first letter of the file/folder name is not shown

This was due to a bug-fix in owncloud activities that have been created between the bug-fix and the fix in activity apps are broken forever, but this is master-only.

what is that »$2a$08$ebx4UI…«?

Looks like a key, did you share it via link with password or something?

older events which were lazily loaded miss the »You added file« text entirely

is related to the same issue as 1.

@jancborchardt

This comment has been minimized.

Show comment
Hide comment
@jancborchardt

jancborchardt May 14, 2014

Member

Folders (when shared) get a »blank page« filetype icon as preview instead of a folder

Member

jancborchardt commented May 14, 2014

Folders (when shared) get a »blank page« filetype icon as preview instead of a folder

@jancborchardt

This comment has been minimized.

Show comment
Hide comment
@jancborchardt

jancborchardt May 14, 2014

Member

@nickvergessen I would say we should fix the preview stuff (with the folders) and then merge this. Everything else is for follow-up pull requests.

cc @owncloud/designers for review.

Member

jancborchardt commented May 14, 2014

@nickvergessen I would say we should fix the preview stuff (with the folders) and then merge this. Everything else is for follow-up pull requests.

cc @owncloud/designers for review.

@nickvergessen nickvergessen changed the title from [WIP] Activity app design to Activity app design May 14, 2014

@nickvergessen

This comment has been minimized.

Show comment
Hide comment
@nickvergessen

nickvergessen May 14, 2014

Contributor

👍 since the workaround has been approved by DeepDiver

Contributor

nickvergessen commented May 14, 2014

👍 since the workaround has been approved by DeepDiver

jancborchardt added a commit that referenced this pull request May 14, 2014

@jancborchardt jancborchardt merged commit 8a45820 into master May 14, 2014

2 checks passed

continuous-integration/travis-ci The Travis CI build passed
Details
default Scrutinizer: 2 updated code elements — Travis: Passed
Details

@jancborchardt jancborchardt deleted the activity-design branch May 14, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment